Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Swap swc_css out #5737

Closed
wants to merge 193 commits into from
Closed

refactor: Swap swc_css out #5737

wants to merge 193 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 16, 2023

Description

Replaces swc_css with lightningcss

Testing Instructions

Let's look at the CI.


Closes WEB-1398

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 3:21am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 3:21am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Rust lints
  • Turbopack Rust checks

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

⚠️ This change may fail to build next-swc.

Logs

packages/next-swc/crates/next-core/src/app_segment_config.rs:158:1: �[38;5;9merror[E0053]: method `description` has an incompatible type for trait
packages/next-swc/crates/next-core/src/app_structure.rs:1133:1: �[38;5;9merror[E0053]: method `description` has an incompatible type for trait
packages/next-swc/crates/next-core/src/babel.rs:150:1: �[38;5;9merror[E0053]: method `description` has an incompatible type for trait
packages/next-swc/crates/next-core/src/next_config.rs:944:1: �[38;5;9merror[E0053]: method `description` has an incompatible type for trait
packages/next-swc/crates/next-core/src/next_font/issue.rs:15:1: �[38;5;9merror[E0053]: method `description` has an incompatible type for trait
packages/next-swc/crates/next-core/src/util.rs:171:1: �[38;5;9merror[E0053]: method `description` has an incompatible type for trait
error: could not compile `next-core` (lib) due to 6 previous errors

See job summary for details

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
passed Passed Secrets high 0  medium 0  low 0  info 0

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@github-actions
Copy link
Contributor

Linux Benchmark for 5da9f15

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6886.40µs ± 16.18µs 6872.88µs ± 25.62µs -0.20%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6356.02µs ± 9.39µs 6392.56µs ± 102.54µs +0.57%
bench_startup/Turbopack CSR/1000 modules 1017.07ms ± 2.29ms 1028.72ms ± 5.21ms +1.14%

@github-actions
Copy link
Contributor

Windows Benchmark for 5da9f15

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 4908.13ms ± 44.47ms 5125.85ms ± 36.55ms +4.44% +1.11%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.97ms ± 0.11ms 15.82ms ± 0.07ms -0.90%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.73ms ± 0.05ms 15.68ms ± 0.02ms -0.32%
bench_startup/Turbopack CSR/1000 modules 4908.13ms ± 44.47ms 5125.85ms ± 36.55ms +4.44% +1.11%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

⚠️ Turbopack Benchmark CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust checks

See workflow summary for details

@kdy1
Copy link
Member Author

kdy1 commented Nov 15, 2023

Closing in favor of #6456

@kdy1 kdy1 closed this Nov 15, 2023
@kdy1 kdy1 deleted the kdy1/swap-css branch November 15, 2023 21:58
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…o#6433)

### Description

This is required for vercel/turborepo#5737


### Testing Instructions



Closes PACK-1953

---------

Co-authored-by: Tobias Koppers <[email protected]>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…o#6433)

### Description

This is required for vercel/turborepo#5737


### Testing Instructions



Closes PACK-1953

---------

Co-authored-by: Tobias Koppers <[email protected]>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…o#6433)

### Description

This is required for vercel/turborepo#5737


### Testing Instructions



Closes PACK-1953

---------

Co-authored-by: Tobias Koppers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants