Make ContainmentTree fully generic #4620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
✅ This changes can build |
Benchmark for d4e09c8Click to view benchmark
|
🟢 CI successful 🟢Thanks |
Base automatically changed from
alexkirsz/web-891-step-3-address-pr-comments-from-step-2
to
main
April 18, 2023 12:51
alexkirsz
force-pushed
the
alexkirsz/generic-containment-tree
branch
from
4ddc6f8 to
f167989
Compare
Benchmark for 794df61Click to view benchmark
|
sokra
approved these changes
Apr 18, 2023
alexkirsz
added
the
pr: automerge
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Apr 20, 2023
### What?
add support for blur placeholder generation to turbopack
add `StructuredImageModuleType` which is used with `ModuleType::Custom`
to allow importing an image as `{ url, width, height, blurDataURL,
blurWidth, blurHeight }`
in contrast to next.js with webpack this will also generate blur
placeholder in development instead of using a _next/image reference.
This should lead to more production-like experience (at the cost of a
little bit of compilation time).
turbo PR: vercel/turborepo#4621
### Why?
Turbopack was crashing on `placeholder="blur"` before.
fixes WEB-534
### Turbopack changes
* vercel/turborepo#4521 <!-- OJ Kwon -
feat(contextcondition): support InPath contextcondition -->
* vercel/turborepo#4601 <!-- Alex Kirszenberg -
Chunking Context Refactor pt. 3: Address PR comments from pt. 2 -->
* vercel/turborepo#4623 <!-- Tobias Koppers -
exclude turborepo from turbopack bench tests -->
* vercel/turborepo#4399 <!-- Leah - support
require.context -->
* vercel/turborepo#4610 <!-- OJ Kwon - test(subset):
add mdx test into subset -->
* vercel/turborepo#4624 <!-- Tobias Koppers - run
benchmarks on windows and macOS too -->
* vercel/turborepo#4620 <!-- Alex Kirszenberg - Make
ContainmentTree fully generic -->
* vercel/turborepo#4600 <!-- Tobias Koppers - add
getChunkPath method -->
* vercel/turborepo#4621 <!-- Tobias Koppers - add
turbopack-image -->
* vercel/turborepo#4639 <!-- Tobias Koppers -
restrict snapshot path for windows path length limit -->
* vercel/turborepo#4641 <!-- Tobias Koppers - put
webp behind a feature flag -->
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
### Description This turns the ContainmentTree struct into a fully generic data structure. The previous PR in this stack already made the chunks values generic, but this goes one step further by making the key type generic as well. ### Testing Instructions Unit test
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This turns the ContainmentTree struct into a fully generic data structure. The previous PR in this stack already made the chunks values generic, but this goes one step further by making the key type generic as well. ### Testing Instructions Unit test
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This turns the ContainmentTree struct into a fully generic data structure. The previous PR in this stack already made the chunks values generic, but this goes one step further by making the key type generic as well. ### Testing Instructions Unit test
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This turns the ContainmentTree struct into a fully generic data structure. The previous PR in this stack already made the chunks values generic, but this goes one step further by making the key type generic as well. ### Testing Instructions Unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This turns the ContainmentTree struct into a fully generic data structure. The previous PR in this stack already made the chunks values generic, but this goes one step further by making the key type generic as well.
Testing Instructions
Unit test