ci: simplify ci config and bump some deps version #2770

promer94 · 2023-09-05T02:28:23Z

No description provided.

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0 0 0 0	View in Orca

codesandbox-ci · 2023-09-05T02:28:55Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

package.json

huozhi · 2024-12-07T00:44:47Z

@promer94 I got it passed, would be appreciated if you can explain a bit what you initially tried to change like why they can be removed. thx

promer94 · 2024-12-07T04:41:51Z

.github/workflows/trigger-release.yml

@@ -20,15 +20,12 @@ on:
 name: Trigger Release

 env:
-  PNPM_VERSION: 8.4.0


pnpm/set-up will read version from package.json

promer94 · 2024-12-07T04:42:50Z

.github/workflows/trigger-release.yml

  SEMVER_TYPE: ${{ github.event.inputs.semverType }}
  RELEASE_TYPE: ${{ github.event.inputs.releaseType }}

 jobs:
  start:
    runs-on: ubuntu-latest
-
-    environment: release-${{ github.event.inputs.releaseType }}-${{ github.event.inputs.semverType }}


I think we dont have multiple enviornments now, so this could be removed

promer94 · 2024-12-07T04:43:14Z

.github/workflows/trigger-release.yml

@@ -53,11 +52,6 @@ jobs:
          node ./scripts/bump-next-version.js

      - name: Git push
-        env:
-            RELEASE_BOT_GITHUB_TOKEN: ${{ secrets.RELEASE_BOT_GITHUB_TOKEN }}


I think git never use this env

huozhi · 2024-12-07T17:20:41Z

Thanks, sounds good!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [swr](https://swr.vercel.app) ([source](https://github.com/vercel/swr)) | dependencies | minor | [`2.2.5` -> `2.3.0`](https://renovatebot.com/diffs/npm/swr/2.2.5/2.3.0) | --- ### Release Notes <details> <summary>vercel/swr (swr)</summary> ### [`v2.3.0`](https://github.com/vercel/swr/releases/tag/v2.3.0) [Compare Source](vercel/swr@v2.2.5...v2.3.0) ##### Feature - Support promises as fallback data by [@shuding](https://github.com/shuding) in vercel/swr#2891 - Allow to use with React 19 by [@vladshcherbin](https://github.com/vladshcherbin) and [@devjiwonchoi](https://github.com/devjiwonchoi) in vercel/swr#3047, vercel/swr#2963 ##### Patches - fix [#3030](vercel/swr#3030) and run relateive test in edge-runtime by [@promer94](https://github.com/promer94) in vercel/swr#3036 - fix: Only suspend when using the `fallback` by [@shuding](https://github.com/shuding) in vercel/swr#3045 - fix type check in tests by [@huozhi](https://github.com/huozhi) in vercel/swr#3052 - fix: Replace the deprecated 'window' with 'globalThis' for Deno by [@saul-atomrigs](https://github.com/saul-atomrigs) in vercel/swr#2915 - fix: check if config.fallback is undefined by [@taku-hatano](https://github.com/taku-hatano) in vercel/swr#2913 - fix(infinte): export SWRInfiniteKeyedMutator type by [@LeoMcA](https://github.com/LeoMcA) in vercel/swr#2900 - fix: Improve comparison performance by [@shuding](https://github.com/shuding) in vercel/swr#2973 - Export ScopedMutator type by [@joshkel](https://github.com/joshkel) in vercel/swr#2937 - Improve-Type-Safety-and-State-Access-in-useStateWithDeps-Hook by [@O-BERNARDOFOEGBU](https://github.com/O-BERNARDOFOEGBU) in vercel/swr#3027 ##### Misc - chore: bump dev deps and change example react version to latest by [@huozhi](https://github.com/huozhi) in vercel/swr#2894 - build: fix beta release job by [@huozhi](https://github.com/huozhi) in vercel/swr#2895 - chore: Improve test coverage by [@shuding](https://github.com/shuding) in vercel/swr#2903 - chore: simplify test coverage strategy by [@huozhi](https://github.com/huozhi) in vercel/swr#2909 - build: simplify react-server export and update bundler by [@huozhi](https://github.com/huozhi) in vercel/swr#2897 - examples: add RSC streaming pre-render with promise fallback example by [@promer94](https://github.com/promer94) in vercel/swr#2905 - Drop client-only by [@huozhi](https://github.com/huozhi) in vercel/swr#2910 - Mark package as side-effect free by [@htunnicliff](https://github.com/htunnicliff) in vercel/swr#2904 - Drop exports module field by [@huozhi](https://github.com/huozhi) in vercel/swr#2911 - chore: update pkg script watch by [@unliar](https://github.com/unliar) in vercel/swr#2920 - test: remove console.error times check by [@promer94](https://github.com/promer94) in vercel/swr#2918 - build: bump bundler for perf by [@huozhi](https://github.com/huozhi) in vercel/swr#2929 - Fix bundling of client entry chunks by [@huozhi](https://github.com/huozhi) in vercel/swr#2932 - ci: fix ci error and upgrade action version by [@promer94](https://github.com/promer94) in vercel/swr#2952 - Add SWRInfiniteMutatorOptions type to export by [@ludwigbacklund](https://github.com/ludwigbacklund) in vercel/swr#2954 - test: update the revalidate function test for useSWRInfinite by [@koba04](https://github.com/koba04) in vercel/swr#2955 - chore: upgrade nextjs dev dep for e2e testing by [@huozhi](https://github.com/huozhi) in vercel/swr#3044 - ci: simplify ci config and bump some deps version by [@promer94](https://github.com/promer94) in vercel/swr#2770 - chore: reorganize entries by [@huozhi](https://github.com/huozhi) in vercel/swr#3048 - Bump bundler and reorganize serialize exports by [@huozhi](https://github.com/huozhi) in vercel/swr#3049 - upgrade use-sync-external-store to support react 19 by [@huozhi](https://github.com/huozhi) in vercel/swr#3050 #### New Contributors - [@htunnicliff](https://github.com/htunnicliff) made their first contribution in vercel/swr#2904 - [@saul-atomrigs](https://github.com/saul-atomrigs) made their first contribution in vercel/swr#2915 - [@unliar](https://github.com/unliar) made their first contribution in vercel/swr#2920 - [@ludwigbacklund](https://github.com/ludwigbacklund) made their first contribution in vercel/swr#2954 - [@taku-hatano](https://github.com/taku-hatano) made their first contribution in vercel/swr#2913 - [@LeoMcA](https://github.com/LeoMcA) made their first contribution in vercel/swr#2900 - [@devjiwonchoi](https://github.com/devjiwonchoi) made their first contribution in vercel/swr#2963 - [@vladshcherbin](https://github.com/vladshcherbin) made their first contribution in vercel/swr#3047 - [@O-BERNARDOFOEGBU](https://github.com/O-BERNARDOFOEGBU) made their first contribution in vercel/swr#3027 **Full Changelog**: vercel/swr@v2.2.5...v2.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/413 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>

promer94 requested review from shuding and huozhi as code owners September 5, 2023 02:28

orca-security-us bot reviewed Sep 5, 2023

View reviewed changes

promer94 force-pushed the simplify-ci branch from 6c9799a to 6fe5b09 Compare September 12, 2023 11:31

huozhi reviewed Sep 25, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

promer94 requested a review from huozhi September 30, 2023 17:15

huozhi force-pushed the simplify-ci branch 2 times, most recently from 8026a67 to 434c3d2 Compare December 7, 2024 00:05

huozhi approved these changes Dec 7, 2024

View reviewed changes

promer94 and others added 2 commits December 7, 2024 01:40

simplify ci

9685d24

revert lock

0d58fc4

huozhi force-pushed the simplify-ci branch from 668324a to 0d58fc4 Compare December 7, 2024 00:41

promer94 commented Dec 7, 2024

View reviewed changes

huozhi merged commit b375be7 into vercel:main Dec 7, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: simplify ci config and bump some deps version #2770

ci: simplify ci config and bump some deps version #2770

promer94 commented Sep 5, 2023

orca-security-us bot left a comment

codesandbox-ci bot commented Sep 5, 2023 •

edited

Loading

huozhi commented Dec 7, 2024

promer94 Dec 7, 2024 •

edited

Loading

promer94 Dec 7, 2024

promer94 Dec 7, 2024

huozhi commented Dec 7, 2024

ci: simplify ci config and bump some deps version #2770

ci: simplify ci config and bump some deps version #2770

Conversation

promer94 commented Sep 5, 2023

orca-security-us bot left a comment

Choose a reason for hiding this comment

Orca Security Scan Summary

codesandbox-ci bot commented Sep 5, 2023 • edited Loading

huozhi commented Dec 7, 2024

promer94 Dec 7, 2024 • edited Loading

Choose a reason for hiding this comment

promer94 Dec 7, 2024

Choose a reason for hiding this comment

promer94 Dec 7, 2024

Choose a reason for hiding this comment

huozhi commented Dec 7, 2024

codesandbox-ci bot commented Sep 5, 2023 •

edited

Loading

promer94 Dec 7, 2024 •

edited

Loading