feat: support configurable deployment basepath #88
+2,960
−3,568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feugy
force-pushed
the
damien/log-766-implement-web-analyticsspeed-insights-randomised-intake
branch
from
92ef234
to
c7a2916
Compare
feugy
force-pushed
the
damien/log-766-implement-web-analyticsspeed-insights-randomised-intake
branch
from
c7a2916
to
58c0f23
Compare
kakadiadarpan
approved these changes
Nov 21, 2024
| @@ -1,20 +1,19 @@ | |||
| import { cssBundleHref } from '@remix-run/css-bundle'; | |||
| // import { cssBundleHref } from '@remix-run/css-bundle'; | |||
There was a problem hiding this comment.
Suggested change
| // import { cssBundleHref } from '@remix-run/css-bundle'; |
Comment on lines
+12
to
+14
| // export const links: LinksFunction = () => [ | ||
| // ...(cssBundleHref ? [{ rel: 'stylesheet', href: cssBundleHref }] : []), | ||
| // ]; |
There was a problem hiding this comment.
Suggested change
| // export const links: LinksFunction = () => [ | |
| // ...(cssBundleHref ? [{ rel: 'stylesheet', href: cssBundleHref }] : []), | |
| // ]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖖 What's in there?
Since ages, we're considering the possibility to configure, at build time, the basepath used for both downloading the injected script and reporting the collected metrics.
This PR brings such capability, and works with our supported frameworks: plain React (CRA), Next, Nuxt, Vue, Sveltkit, Astro, Remix (only when used with vite).
🤺 How to test?
Check the vercel deployments of each example app.
To reproduce locally, and set custom basepath:
pnpm i && pnpm -F @vercel/speed-insights buildThen:
For Nextjs app
NEXT_PUBLIC_VERCEL_OBSERVABILITY_BASEPATH="/abc" pnpm -F nextjs build pnpm -F nextjs startbrowse to http://localhost:3000 and check your console: it's trying (and failing) to download
/abc/insights/script.jsFor Sveltekit app
VITE_VERCEL_OBSERVABILITY_BASEPATH="/hij" pnpm -F svelte build pnpm -F svelte previewbrowse to http://localhost:4173 and check your console: it's trying (and failing) to download
/hij/insights/script.jsFor vue app
VITE_VERCEL_OBSERVABILITY_BASEPATH="/klm" pnpm -F vue build pnpm -F vue previewbrowse to http://localhost:4173 and check your console: it's trying (and failing) to download
/klm/insights/script.jsFor nuxt app
VITE_VERCEL_OBSERVABILITY_BASEPATH="/nop" pnpm -F nuxt build pnpm -F nuxt previewbrowse to http://localhost:3000 and check your console: it's trying (and failing) to download
/nop/insights/script.jsFor remix app
VITE_VERCEL_OBSERVABILITY_BASEPATH="/qrs" pnpm -F remix build pnpm -F remix startbrowse to http://localhost:3000 and check your console: it's trying (and failing) to download
/qrs/insights/script.jsFor astro app
PUBLIC_VERCEL_OBSERVABILITY_BASEPATH="/tuv" pnpm -F astro build pnpm -F astro previewbrowse to http://localhost:4321 and check your console: it's trying (and failing) to download
/tuv/insights/script.jsThere is no example for CRA.
🔬Notes to reviewers
This is a generic solution, heavily inspired by @emspishak (thanks for the work!), and would replace #87.
I've changed the example app for Remix to used the vite, as per the latest official recommendation (remix 2.14 to date).
I've also replaced Jest with vitest, because the primer couldn't handle
import.metaproperly. And it's superior in my opinion (look at the reduced number of deps and shorter configuration).🔗 Related PRs