Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error templates #25

Merged
merged 3 commits into from
Jun 12, 2018
Merged

Added error templates #25

merged 3 commits into from
Jun 12, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented Jun 12, 2018

Once this is released, the handler will automatically determine the right error format if one occurs and then sends it to the client in that format.

Furthermore, this allows people to not just specifiy an error template for 404 errors, but also for all other errors that can occur (e.g. 400 or 500).

Just add a <status-code>.html file to the root directory and you're good.

@leo leo added the enhancement New feature or request label Jun 12, 2018
@leo leo requested a review from OlliV June 12, 2018 12:34
Copy link

@OlliV OlliV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I want .asp instead of .html :trollface:

@leo leo merged commit 33ea577 into master Jun 12, 2018
@leo leo deleted the 404-template branch June 12, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants