build: don't strip global symbols of macOS binaries

Bug: vercel/pkg#1155
vercel · May 10, 2021 · 5d2bc3b · 5d2bc3b
1 parent a062bb4
commit 5d2bc3b
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/build.ts b/lib/build.ts
@@ -201,9 +201,14 @@ async function compileOnUnix(
 
   const output = path.join(nodePath, 'out/Release/node');
 
-  await spawn(process.env.STRIP || 'strip', [output], {
-    stdio: 'inherit',
-  });
+  await spawn(
+    process.env.STRIP || 'strip',
+    // global symbols are required for native bindings on macOS
+    [...(targetPlatform === 'macos' ? ['-x'] : []), output],
+    {
+      stdio: 'inherit',
+    }
+  );
 
   if (targetPlatform === 'macos') {
     // Newer versions of Apple Clang automatically ad-hoc sign the compiled executable.