Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pretty message if port already in use(#927) #932

Merged
merged 10 commits into from
Feb 1, 2017
Merged

add pretty message if port already in use(#927) #932

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0efd6f9
add pretty message if port already use(#927)
dex157 Jan 30, 2017
30e77d1
fix console async nature
dex157 Jan 30, 2017
d675deb
fix linter
dex157 Jan 30, 2017
cb9b3b3
clean callbacks code
dex157 Jan 31, 2017
9f6ccce
Check package.json for the startup script
dex157 Jan 31, 2017
f55b901
fix path to package
dex157 Jan 31, 2017
8de2b51
omit callback
dex157 Jan 31, 2017
9404483
remove extra check, code execute in try block
dex157 Jan 31, 2017
0278e8b
+ reason for change start listen port of node http
dex157 Jan 31, 2017
6d7945c
remove extra code for search package
dex157 Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions bin/next-dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import 'source-map-support/register'
import { resolve, join } from 'path'
import parseArgs from 'minimist'
import { existsSync } from 'fs'
import { existsSync, readFileSync } from 'fs'
import Server from '../server'
import { printAndExit } from '../lib/utils'

Expand Down Expand Up @@ -61,6 +61,16 @@ srv.start(argv.port)
}
})
.catch((err) => {
console.error(err)
process.exit(1)
if (err.code === 'EADDRINUSE') {
let errorMessage = `Port ${argv.port} is already in use.`
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a try catch block here.

const appPackage = JSON.parse(readFileSync(join(dir, 'package.json'), 'utf8'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use pkg-up to find the package.json. Dir could be a directory inside root. In that case, there will be no package.json in the dir.

const nextTuple = Object.entries(appPackage.scripts).find(i => i[1] === 'next')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happen when we don't find a one. Then do nothing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's possible for users to give some additional stuff to the next command like: next custom-dir-name

errorMessage += `\nUse \`npm run ${nextTuple[0]} -- -p <some other port>\`.`
} catch (e) { }
console.error(errorMessage)
} else {
console.error(err)
}
process.nextTick(() => process.exit(1))
})
7 changes: 3 additions & 4 deletions server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,9 @@ export default class Server {
await this.prepare()
this.http = http.createServer(this.getRequestHandler())
await new Promise((resolve, reject) => {
this.http.listen(port, (err) => {
if (err) return reject(err)
resolve()
})
this.http.on('error', reject)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to do this?
I think this change has nothing to do with this PR.
If so, remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunoda

this.http.listen(port, (err) => {

This code does not catch the error when next starting listen port which already in use

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.
Then add that as a comment.

this.http.on('listening', () => resolve())
this.http.listen(port)
})
}

Expand Down