Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack with latest acorn #7795

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Upgrade to webpack with latest acorn #7795

merged 1 commit into from
Jul 8, 2019

Conversation

Timer
Copy link
Member

@Timer Timer commented Jul 8, 2019

Closes #6240

@Timer Timer added Type: Bug Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.). labels Jul 8, 2019
@Timer Timer added this to the 9.0.1 milestone Jul 8, 2019
@Timer Timer requested review from ijjk, lfades and timneutkens as code owners July 8, 2019 19:28
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2019

Stats from current PR

Click to expand stats
zeit/next.js canary zeit/next.js upgrade-webpack Change
Build Duration 12.9s 12.9s -91ms
node_modules Size 45.4 MB 45.4 MB -1.59 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.45 kB 8.45 kB
Client _error gzip Size 3.24 kB 3.24 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.03 kB 2.03 kB
Client pages/routerDirect Size 423 B 423 B
Client pages/routerDirect gzip Size 306 B 306 B
Client pages/withRouter Size 435 B 435 B
Client pages/withRouter gzip Size 301 B 301 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.97 kB 7.97 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.5 kB 59.5 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.36 kB 1.36 kB
Build Dir Size 785 kB 785 kB
Click to expand serverless stats
zeit/next.js canary zeit/next.js upgrade-webpack Change
Build Duration 14.5s 14.3s -211ms
node_modules Size 45.4 MB 45.4 MB -1.59 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB -1 B
Client _error Size 8.45 kB 8.45 kB
Client _error gzip Size 3.24 kB 3.24 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 224 B ⚠️ +2 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.03 kB 2.03 kB
Client pages/routerDirect Size 423 B 423 B
Client pages/routerDirect gzip Size 306 B 306 B
Client pages/withRouter Size 435 B 435 B
Client pages/withRouter gzip Size 301 B 300 B -1 B
Client main Size 24.3 kB 24.3 kB
Client main gzip Size 7.97 kB 7.97 kB -1 B
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.5 kB 59.5 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 338 kB 338 kB ⚠️ +84 B
Serverless pages/link gzip Size 86.7 kB 86.7 kB ⚠️ +14 B
Serverless pages/index Size Error getting size Error getting size
Serverless pages/index gzip Size Error getting size Error getting size
Serverless pages/_error Size 328 kB 328 kB ⚠️ +84 B
Serverless pages/_error gzip Size 84 kB 84 kB ⚠️ +14 B
Serverless pages/routerDirect Size 329 kB 329 kB ⚠️ +84 B
Serverless pages/routerDirect gzip Size 84.3 kB 84.3 kB ⚠️ +13 B
Serverless pages/withRouter Size 329 kB 329 kB ⚠️ +84 B
Serverless pages/withRouter gzip Size 84.2 kB 84.2 kB ⚠️ +19 B
Build Dir Size 2.04 MB 2.04 MB ⚠️ +336 B

@Timer Timer merged commit b013e11 into canary Jul 8, 2019
@Timer Timer deleted the upgrade-webpack branch July 8, 2019 19:37
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Upstream Related to using Next.js with a third-party dependency. (e.g., React, UI/icon libraries, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.0.0 - dynamic import causing 'You may need an appropriate loader...' error
2 participants