Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write errors.json fully formatted #74753

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 10, 2025

Prettier would write this newline anyway.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 10, 2025
Copy link
Member Author

eps1lon commented Jan 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eps1lon eps1lon requested a review from gaojude January 10, 2025 15:26
@eps1lon eps1lon marked this pull request as ready for review January 10, 2025 15:26
@ijjk
Copy link
Member

ijjk commented Jan 10, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
buildDuration 21.9s 18.6s N/A
buildDurationCached 17.8s 15.2s N/A
nodeModulesSize 417 MB 417 MB
nextStartRea..uration (ms) 509ms 498ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
index.html gzip 522 B 521 B N/A
link.html gzip 538 B 535 B N/A
withRouter.html gzip 518 B 518 B
Overall change 518 B 518 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
middleware-b..fest.js gzip 672 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 368 kB 368 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 138 kB 138 kB
app-page.run...dev.js gzip 356 kB 356 kB
app-page.run..prod.js gzip 126 kB 126 kB
app-route-ex...dev.js gzip 37.6 kB 37.6 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.46 MB 2.46 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/01-10-write_errors.json_fully_formatted Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 75.7 kB 76 kB ⚠️ +310 B
Overall change 75.7 kB 76 kB ⚠️ +310 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 8891335

@ijjk
Copy link
Member

ijjk commented Jan 10, 2025

Failing test suites

Commit: 8891335

pnpm test-start-turbo test/e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts (turbopack)

  • segment cache (incremental opt in) > prefetches a shared layout on a PPR-enabled route that was previously omitted from a non-PPR-enabled route
  • segment cache (incremental opt in) > multiple prefetches to same link are deduped > page with PPR disabled
Expand output

● segment cache (incremental opt in) › multiple prefetches to same link are deduped › page with PPR disabled

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  89 |     it('page with PPR enabled, and has a dynamic param', () =>
  90 |       testPrefetchDeduping('/ppr-enabled/dynamic-param'))
> 91 |     it('page with PPR disabled', () => testPrefetchDeduping('/ppr-disabled'))
     |     ^
  92 |     it('page with PPR disabled, and has a loading boundary', () =>
  93 |       testPrefetchDeduping('/ppr-disabled-with-loading-boundary'))
  94 |   })

  at it (e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts:91:5)
  at describe (e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts:87:3)
  at Object.describe (e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts:5:1)

● segment cache (incremental opt in) › prefetches a shared layout on a PPR-enabled route that was previously omitted from a non-PPR-enabled route

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  94 |   })
  95 |
> 96 |   it(
     |   ^
  97 |     'prefetches a shared layout on a PPR-enabled route that was previously ' +
  98 |       'omitted from a non-PPR-enabled route',
  99 |     async () => {

  at it (e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts:96:3)
  at Object.describe (e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts:5:1)

Read more about building and testing Next.js in contributing.md.

@eps1lon eps1lon enabled auto-merge (squash) January 10, 2025 16:37
@eps1lon eps1lon merged commit dd79127 into canary Jan 10, 2025
125 of 130 checks passed
@eps1lon eps1lon deleted the sebbie/01-10-write_errors.json_fully_formatted branch January 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants