Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(turbopack-core): Use ResolvedVc for IntrospectableModule and IntrospectableSource #74512

Merged
merged 1 commit into from
Jan 9, 2025
Merged

refactor(turbopack-core): Use ResolvedVc for IntrospectableModule and IntrospectableSource #74512

merged 1 commit into from
Jan 9, 2025
+12 −12

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 4, 2025 •
edited by padmaia
Loading

Closes PACK-3699

This was referenced Jan 4, 2025
Open
Open
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 4, 2025
This was referenced Jan 4, 2025
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 4, 2025
Merged
Merged
@bgw bgw requested a review from kdy1 January 4, 2025 01:07
@bgw bgw marked this pull request as ready for review January 4, 2025 01:07
@ijjk
Copy link
Member

ijjk commented Jan 4, 2025 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 4, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
buildDuration 41.9s 37.2s N/A
buildDurationCached 35.7s 32.1s N/A
nodeModulesSize 418 MB 418 MB ✓
nextStartRea..uration (ms) 964ms 1s N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
index.html gzip 523 B 523 B ✓
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
middleware-b..fest.js gzip 669 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 368 kB 368 kB ✓
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 355 kB 355 kB ✓
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.46 MB 2.46 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js bgw/resolved-introspectable-module-and-source Change
0.pack gzip 2.09 MB 2.1 MB ⚠️ +9.96 kB
index.pack gzip 75.6 kB 75.2 kB N/A
Overall change 2.09 MB 2.1 MB ⚠️ +9.96 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 9a70357

@bgw bgw force-pushed the bgw/resolved-process-result branch from 3f4d0cc to e1a4092 Compare January 6, 2025 20:03
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from 6d969e6 to cfef664 Compare January 6, 2025 20:03
@bgw bgw force-pushed the bgw/resolved-process-result branch from e1a4092 to 83eba5d Compare January 8, 2025 22:47
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from cfef664 to e8bc4e5 Compare January 8, 2025 22:47
@bgw bgw force-pushed the bgw/resolved-process-result branch from 83eba5d to af41f22 Compare January 9, 2025 00:37
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from e8bc4e5 to df0df8c Compare January 9, 2025 00:38
@bgw bgw force-pushed the bgw/resolved-process-result branch from af41f22 to 162cd25 Compare January 9, 2025 05:56
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from df0df8c to a478323 Compare January 9, 2025 05:57
@bgw bgw force-pushed the bgw/resolved-process-result branch from 162cd25 to bd8bb7f Compare January 9, 2025 17:00
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from a478323 to 2d0edf9 Compare January 9, 2025 17:01
@bgw bgw force-pushed the bgw/resolved-process-result branch 2 times, most recently from 7124286 to 40d14cf Compare January 9, 2025 18:10
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from 2d0edf9 to ef686e3 Compare January 9, 2025 18:10
@bgw bgw changed the base branch from bgw/resolved-process-result to graphite-base/74512 January 9, 2025 19:07
@bgw bgw force-pushed the graphite-base/74512 branch from 40d14cf to a0eab62 Compare January 9, 2025 19:07
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from ef686e3 to 2fa29a9 Compare January 9, 2025 19:07
@bgw bgw changed the base branch from graphite-base/74512 to canary January 9, 2025 19:08
@bgw bgw force-pushed the bgw/resolved-introspectable-module-and-source branch from 2fa29a9 to 9a70357 Compare January 9, 2025 19:08
@bgw bgw merged commit fa422ce into canary Jan 9, 2025
125 of 130 checks passed
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 9, 2025

Merge activity

  • Jan 9, 4:12 PM EST: A user merged this pull request with Graphite.

@bgw bgw deleted the bgw/resolved-introspectable-module-and-source branch January 9, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @kdy1