Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metadata] Merge the metadata resolve apis into one api #74191

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Dec 20, 2024

What

Merge the two steps of resolving metadata or viewport into one, simplifying the usage on the Metadata and Viewport component side, that they only used one API provided by the resolving logic module.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 20, 2024
Copy link
Member Author

huozhi commented Dec 20, 2024

@ijjk
Copy link
Member

ijjk commented Dec 20, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
buildDuration 25.5s 22.7s N/A
buildDurationCached 21.3s 18.4s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +10.7 kB
nextStartRea..uration (ms) 588ms 581ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 359 kB 359 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 347 kB 347 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.44 MB 2.44 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-20-merge_metadata_resolve_api Change
0.pack gzip 2.08 MB 2.09 MB ⚠️ +10.9 kB
index.pack gzip 74.6 kB 73.7 kB N/A
Overall change 2.08 MB 2.09 MB ⚠️ +10.9 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: a6b85dd

@ijjk
Copy link
Member

ijjk commented Dec 20, 2024

Tests Passed

@huozhi huozhi changed the title [metadata] merge the metadata resolve api exposed to components [metadata] Merge the metadata resolve apis into one api Dec 20, 2024
Base automatically changed from 12-17-separate_prefetch_head to canary December 20, 2024 22:12
@huozhi huozhi force-pushed the 12-20-merge_metadata_resolve_api branch 2 times, most recently from afe3ac4 to 33a88ba Compare December 23, 2024 14:44
@huozhi huozhi marked this pull request as ready for review December 23, 2024 17:15
@huozhi huozhi requested review from ztanner and gnoff December 23, 2024 17:15
@huozhi huozhi force-pushed the 12-20-merge_metadata_resolve_api branch from 33a88ba to 24c3a41 Compare December 23, 2024 17:38
@huozhi huozhi requested a review from ztanner December 23, 2024 22:56
@huozhi huozhi merged commit 7a47ed5 into canary Dec 23, 2024
128 of 130 checks passed
@huozhi huozhi deleted the 12-20-merge_metadata_resolve_api branch December 23, 2024 23:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants