Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Geist font in Dev Overlay #74160

Merged
merged 2 commits into from
Dec 20, 2024
+8 −3
Merged

Use Geist font in Dev Overlay #74160

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
569643e
Use Geist font in Dev Overlay
devjiwonchoi Dec 19, 2024
c1b0f10
import Geist Google Font
devjiwonchoi Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/next/src/client/components/react-dev-overlay/_experimental/internal/styles/Base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ export function Base() {
return (
<style>
{css`
@import url('https://fonts.googleapis.com/css2?family=Geist:wght@400;900&family=Geist+Mono:wght@400;900&display=swap');

Comment on lines +8 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nit: ideally, this can be bundled in so we dont need to download from google

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could pre-download it in the taskfile so it's still updated whenever we do a release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revisit to use local woff2 later!

:host {
--size-gap-half: 4px;
--size-gap: 8px;
Expand Down Expand Up @@ -35,9 +37,10 @@ export function Base() {
--color-text-color-red-1: #ff5555;
--color-text-background-red-1: #fff9f9;

--font-stack-monospace: 'SFMono-Regular', Consolas, 'Liberation Mono',
Menlo, Courier, monospace;
--font-stack-sans: -apple-system, 'Source Sans Pro', sans-serif;
--font-stack-monospace: 'Geist Mono', 'SFMono-Regular', Consolas,
'Liberation Mono', Menlo, Courier, monospace;
--font-stack-sans: 'Geist', -apple-system, 'Source Sans Pro',
sans-serif;

--color-ansi-selection: rgba(95, 126, 151, 0.48);
--color-ansi-bg: #111111;
Expand All @@ -59,6 +62,8 @@ export function Base() {
--color-ansi-bright-magenta: #cebbff;
--color-ansi-bright-red: #ff8888;
--color-ansi-bright-yellow: #ffd966;

font-family: var(--font-stack-sans);
}

@media (prefers-color-scheme: dark) {
Expand Down
Loading