Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storybook for UI testing #74032

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 17, 2024

Why?

This PR initialized the Storybook for UI, a11y, and screen testing for Dev Overlay and future potential.

Closes NDX-587

Copy link
Member Author

devjiwonchoi commented Dec 17, 2024

@devjiwonchoi devjiwonchoi force-pushed the 12-17-delete_unused_groupedstackframes.tsx_ branch from 701e63b to 306b784 Compare December 17, 2024 16:35
@devjiwonchoi devjiwonchoi force-pushed the 12-18-add_storybook_for_ui_testing branch from aaeb27c to 97376a1 Compare December 17, 2024 16:35
@devjiwonchoi devjiwonchoi changed the base branch from 12-17-delete_unused_groupedstackframes.tsx_ to 12-17-fork_react-dev-overlay_for_new_ui December 17, 2024 16:35
@devjiwonchoi devjiwonchoi marked this pull request as ready for review December 17, 2024 16:43
@devjiwonchoi devjiwonchoi force-pushed the 12-17-fork_react-dev-overlay_for_new_ui branch from e086c37 to b291d84 Compare December 17, 2024 16:48
@devjiwonchoi devjiwonchoi force-pushed the 12-18-add_storybook_for_ui_testing branch from 97376a1 to 29ad386 Compare December 17, 2024 16:48
Copy link

socket-security bot commented Dec 17, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@chromatic-com/[email protected] None 0 599 kB ghengeveld

View full report↗︎

@devjiwonchoi devjiwonchoi force-pushed the 12-18-add_storybook_for_ui_testing branch from 29ad386 to 567e8f5 Compare December 17, 2024 17:01
@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
buildDuration 28.9s 29.8s ⚠️ +838ms
buildDurationCached 28.3s 24.2s N/A
nodeModulesSize 415 MB 415 MB ⚠️ +1.36 kB
nextStartRea..uration (ms) 871ms 636ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
1187-HASH.js gzip 51.4 kB 51.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 521 B N/A
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 354 kB 354 kB N/A
app-page-exp..prod.js gzip 128 kB 128 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page-tur..prod.js gzip 136 kB 136 kB
app-page.run...dev.js gzip 344 kB 344 kB
app-page.run..prod.js gzip 124 kB 124 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39.1 kB 39.1 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.07 MB 2.07 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-18-add_storybook_for_ui_testing Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 73 kB 75.7 kB ⚠️ +2.68 kB
Overall change 73 kB 75.7 kB ⚠️ +2.68 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Commit: 788086f

@devjiwonchoi devjiwonchoi force-pushed the 12-17-fork_react-dev-overlay_for_new_ui branch 2 times, most recently from a95f901 to 076d5df Compare December 17, 2024 17:20
@devjiwonchoi devjiwonchoi force-pushed the 12-18-add_storybook_for_ui_testing branch from 567e8f5 to 38d7725 Compare December 17, 2024 17:20
@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Tests Passed

@devjiwonchoi devjiwonchoi changed the base branch from 12-17-fork_react-dev-overlay_for_new_ui to graphite-base/74032 December 18, 2024 01:20
@devjiwonchoi devjiwonchoi force-pushed the 12-18-add_storybook_for_ui_testing branch from 38d7725 to 04a9592 Compare December 18, 2024 01:20
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74032 to canary December 18, 2024 01:21
@devjiwonchoi devjiwonchoi force-pushed the 12-18-add_storybook_for_ui_testing branch from 04a9592 to 788086f Compare December 18, 2024 01:21
@devjiwonchoi devjiwonchoi merged commit a12192c into canary Dec 18, 2024
125 of 130 checks passed
Copy link
Member Author

Merge activity

  • Dec 17, 8:55 PM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi deleted the 12-18-add_storybook_for_ui_testing branch December 18, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants