-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storybook for UI testing #74032
Merged
Merged
Add storybook for UI testing #74032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
devjiwonchoi
force-pushed
the
12-17-delete_unused_groupedstackframes.tsx_
branch
from
December 17, 2024 16:35
701e63b
to
306b784
Compare
devjiwonchoi
force-pushed
the
12-18-add_storybook_for_ui_testing
branch
from
December 17, 2024 16:35
aaeb27c
to
97376a1
Compare
devjiwonchoi
changed the base branch from
12-17-delete_unused_groupedstackframes.tsx_
to
12-17-fork_react-dev-overlay_for_new_ui
December 17, 2024 16:35
devjiwonchoi
force-pushed
the
12-17-fork_react-dev-overlay_for_new_ui
branch
from
December 17, 2024 16:48
e086c37
to
b291d84
Compare
devjiwonchoi
force-pushed
the
12-18-add_storybook_for_ui_testing
branch
from
December 17, 2024 16:48
97376a1
to
29ad386
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
devjiwonchoi
force-pushed
the
12-18-add_storybook_for_ui_testing
branch
from
December 17, 2024 17:01
29ad386
to
567e8f5
Compare
gaojude
approved these changes
Dec 17, 2024
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
buildDuration | 28.9s | 29.8s | |
buildDurationCached | 28.3s | 24.2s | N/A |
nodeModulesSize | 415 MB | 415 MB | |
nextStartRea..uration (ms) | 871ms | 636ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
1187-HASH.js gzip | 51.4 kB | 51.4 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.36 kB | 5.36 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 232 B | 235 B | N/A |
main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.49 kB | 4.49 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 746 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
index.html gzip | 524 B | 524 B | ✓ |
link.html gzip | 539 B | 538 B | N/A |
withRouter.html gzip | 520 B | 521 B | N/A |
Overall change | 524 B | 524 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 204 kB | 204 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 671 B | 667 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
523-experime...dev.js gzip | 322 B | 322 B | ✓ |
523.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 354 kB | 354 kB | N/A |
app-page-exp..prod.js gzip | 128 kB | 128 kB | ✓ |
app-page-tur..prod.js gzip | 141 kB | 141 kB | ✓ |
app-page-tur..prod.js gzip | 136 kB | 136 kB | ✓ |
app-page.run...dev.js gzip | 344 kB | 344 kB | ✓ |
app-page.run..prod.js gzip | 124 kB | 124 kB | ✓ |
app-route-ex...dev.js gzip | 37.5 kB | 37.5 kB | ✓ |
app-route-ex..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
app-route.ru...dev.js gzip | 39.1 kB | 39.1 kB | ✓ |
app-route.ru..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.07 MB | 2.07 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 12-18-add_storybook_for_ui_testing | Change | |
---|---|---|---|
0.pack gzip | 2.08 MB | 2.08 MB | N/A |
index.pack gzip | 73 kB | 75.7 kB | |
Overall change | 73 kB | 75.7 kB |
Diff details
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
devjiwonchoi
force-pushed
the
12-17-fork_react-dev-overlay_for_new_ui
branch
2 times, most recently
from
December 17, 2024 17:20
a95f901
to
076d5df
Compare
devjiwonchoi
force-pushed
the
12-18-add_storybook_for_ui_testing
branch
from
December 17, 2024 17:20
567e8f5
to
38d7725
Compare
Tests Passed |
eps1lon
approved these changes
Dec 17, 2024
devjiwonchoi
changed the base branch from
12-17-fork_react-dev-overlay_for_new_ui
to
graphite-base/74032
December 18, 2024 01:20
devjiwonchoi
force-pushed
the
12-18-add_storybook_for_ui_testing
branch
from
December 18, 2024 01:20
38d7725
to
04a9592
Compare
devjiwonchoi
force-pushed
the
graphite-base/74032
branch
from
December 18, 2024 01:20
076d5df
to
035f161
Compare
devjiwonchoi
force-pushed
the
12-18-add_storybook_for_ui_testing
branch
from
December 18, 2024 01:21
04a9592
to
788086f
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This PR initialized the Storybook for UI, a11y, and screen testing for Dev Overlay and future potential.
Closes NDX-587