Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up react-dev-overlay before fork #74016

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 17, 2024

Clean up react-dev-overlay/ before forking for new UI.

  • Ported pages/ReactDevOverlay/tsx logic to a hook.
  • Moved client-entry.tsx to app/ as it's only used in app router.

Closes NDX-590

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 17, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
buildDuration 18.9s 15.9s N/A
buildDurationCached 14.9s 12.9s N/A
nodeModulesSize 410 MB 410 MB ⚠️ +8.71 kB
nextStartRea..uration (ms) 454ms 456ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
1187-HASH.js gzip 51.1 kB 51.1 kB
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 51.1 kB 51.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
middleware-b..fest.js gzip 672 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 314 kB 314 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.4 kB 37.4 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39 kB 39 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-17-move_client-entry.tsx_to_app_ Change
0.pack gzip 2.06 MB 2.06 MB ⚠️ +1.19 kB
index.pack gzip 72.7 kB 71.8 kB N/A
Overall change 2.06 MB 2.06 MB ⚠️ +1.19 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: bef58f6

@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Tests Passed

@devjiwonchoi devjiwonchoi marked this pull request as ready for review December 17, 2024 11:09
}
}, [dispatch])

const onComponentError = React.useCallback(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this later since this not really being used

@devjiwonchoi devjiwonchoi changed the title move client-entry.tsx to app/ Clean up react-dev-overlay before fork Dec 17, 2024
@devjiwonchoi devjiwonchoi merged commit 62c2f74 into canary Dec 17, 2024
132 checks passed
Copy link
Member Author

Merge activity

  • Dec 17, 6:35 AM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi deleted the 12-17-move_client-entry.tsx_to_app_ branch December 17, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants