Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add eslint check for mdx #74009

Merged
merged 6 commits into from
Dec 17, 2024
Merged

chore: add eslint check for mdx #74009

merged 6 commits into from
Dec 17, 2024

Conversation

samcx
Copy link
Member

@samcx samcx commented Dec 16, 2024

Why?

MDX changes are not getting properly linted, causing upstream issues.

When trying to push this incorrect change:

<Image
  alt="Route segments for dynamic MDX components"
  srcLight="/docs/light/mdx-files.png"
  srcDark="/docs/dark/mdx-files.png"
  width="1600"
  height="849"
>

CleanShot 2024-12-16 at 16 14 00@2x

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Dec 16, 2024
Copy link
Member Author

samcx commented Dec 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@samcx samcx marked this pull request as ready for review December 16, 2024 23:48
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Dec 17, 2024
@samcx samcx removed the Documentation Related to Next.js' official documentation. label Dec 17, 2024
@samcx samcx requested a review from gaojude December 17, 2024 00:16
@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sam/ci-mdx Change
buildDuration 20s 17.9s N/A
buildDurationCached 16.9s 14.5s N/A
nodeModulesSize 410 MB 410 MB
nextStartRea..uration (ms) 499ms 501ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sam/ci-mdx Change
1187-HASH.js gzip 51 kB 51 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sam/ci-mdx Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sam/ci-mdx Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sam/ci-mdx Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sam/ci-mdx Change
index.html gzip 524 B 523 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 520 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sam/ci-mdx Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sam/ci-mdx Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sam/ci-mdx Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 323 kB 323 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 314 kB 314 kB
app-page.run..prod.js gzip 123 kB 123 kB
app-route-ex...dev.js gzip 37.4 kB 37.4 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.3 kB 25.3 kB
app-route.ru...dev.js gzip 39 kB 39 kB
app-route.ru..prod.js gzip 25.3 kB 25.3 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.4 kB 27.4 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.36 MB 2.36 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sam/ci-mdx Change
0.pack gzip 2.06 MB 2.07 MB ⚠️ +3.96 kB
index.pack gzip 72.9 kB 73.5 kB ⚠️ +591 B
Overall change 2.14 MB 2.14 MB ⚠️ +4.55 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 7ef786e

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] eval Transitive: environment, filesystem, shell +64 2.37 MB wooorm

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Dec 17, 2024

Tests Passed

@samcx samcx merged commit 61bfaa5 into canary Dec 17, 2024
125 of 130 checks passed
@samcx samcx deleted the sam/ci-mdx branch December 17, 2024 01:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants