-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added error when there's missing root params in generateStaticParams #73933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2024
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
buildDuration | 31.2s | 20.2s | N/A |
buildDurationCached | 19.3s | 16.4s | N/A |
nodeModulesSize | 410 MB | 410 MB | |
nextStartRea..uration (ms) | 567ms | 535ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
1187-HASH.js gzip | 51.4 kB | 51.4 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.36 kB | 5.36 kB | N/A |
bccd1874-HASH.js gzip | 53 kB | 53 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 232 B | 235 B | N/A |
main-HASH.js gzip | 34.1 kB | 34 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.49 kB | 4.49 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 746 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
index.html gzip | 524 B | 523 B | N/A |
link.html gzip | 539 B | 537 B | N/A |
withRouter.html gzip | 520 B | 519 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 204 kB | 204 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 671 B | 667 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.2 kB | 31.2 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
523-experime...dev.js gzip | 322 B | 322 B | ✓ |
523.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 324 kB | 324 kB | ✓ |
app-page-exp..prod.js gzip | 128 kB | 128 kB | ✓ |
app-page-tur..prod.js gzip | 141 kB | 141 kB | ✓ |
app-page-tur..prod.js gzip | 136 kB | 136 kB | ✓ |
app-page.run...dev.js gzip | 314 kB | 314 kB | ✓ |
app-page.run..prod.js gzip | 124 kB | 124 kB | ✓ |
app-route-ex...dev.js gzip | 37.4 kB | 37.4 kB | ✓ |
app-route-ex..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
app-route.ru...dev.js gzip | 39 kB | 39 kB | ✓ |
app-route.ru..prod.js gzip | 25.3 kB | 25.3 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.4 kB | 27.4 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.36 MB | 2.36 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js feat/error-for-missing-root-params | Change | |
---|---|---|---|
0.pack gzip | 2.05 MB | 2.05 MB | |
index.pack gzip | 72.6 kB | 73.7 kB | |
Overall change | 2.12 MB | 2.12 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 14, 2024 04:46
0520878
to
0f4adf8
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
2 times, most recently
from
December 14, 2024 04:58
6ed450b
to
0faa33e
Compare
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 16, 2024 20:06
0f4adf8
to
9cb16ca
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
2 times, most recently
from
December 16, 2024 20:07
39fa7a6
to
040105c
Compare
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 16, 2024 20:11
9cb16ca
to
60a36f3
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 16, 2024 20:11
040105c
to
5fb1001
Compare
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 16, 2024 20:13
60a36f3
to
b51ca16
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
2 times, most recently
from
December 16, 2024 21:17
8128f04
to
d5027c3
Compare
wyattjoh
changed the title
feat: added error when there's missing root params
feat: added error when there's missing root params in generateStaticParams
Dec 16, 2024
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 16, 2024 22:17
b51ca16
to
386d2ec
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 16, 2024 22:17
d5027c3
to
f8063e7
Compare
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 16, 2024 22:29
386d2ec
to
18cb80b
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 16, 2024 22:30
f8063e7
to
2d00545
Compare
ztanner
approved these changes
Dec 16, 2024
test/e2e/app-dir/ppr-missing-root-params/fixtures/multiple/next.config.js
Show resolved
Hide resolved
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 16, 2024 23:44
18cb80b
to
e689a21
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 16, 2024 23:44
2d00545
to
d57b374
Compare
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
from
December 17, 2024 16:28
e689a21
to
acb0ab9
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 17, 2024 16:29
d57b374
to
768a253
Compare
wyattjoh
force-pushed
the
feat/generate-partial-shells
branch
2 times, most recently
from
December 17, 2024 17:17
28c6ea2
to
d54fc94
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 17, 2024 17:17
768a253
to
1d7ce5a
Compare
wyattjoh
changed the base branch from
feat/generate-partial-shells
to
graphite-base/73933
December 17, 2024 17:56
wyattjoh
force-pushed
the
graphite-base/73933
branch
from
December 17, 2024 17:57
d54fc94
to
c422755
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 17, 2024 17:57
1d7ce5a
to
2e244ed
Compare
wyattjoh
force-pushed
the
feat/error-for-missing-root-params
branch
from
December 17, 2024 17:57
2e244ed
to
79b8c7e
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When partial prerendering is enabled, this enables a build time error that prints when there are no root params provided using
generateStaticParams
. This ensures that we're able to test the code around invocations ofrootParams()
for other dynamic usage.