Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ChunkItems reference only OutputAssets #73824

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Make ChunkItems reference only OutputAssets #73824

merged 9 commits into from
Dec 17, 2024

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Dec 12, 2024 •
edited by padmaia
Loading

This:

  • Changes ChunkItem’s references implementation to only allow items to reference OutputAssets
  • Implements a default references that returns an empty set of output assets
  • Updates logic for using these output assets in make_chunk_group
  • Moves logic for using the inner module’s references into areas that need it

Closes PACK-3664

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Dec 12, 2024
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/chunk-item-output-asset-references branch from 96caf92 to c009176 Compare December 12, 2024 01:01
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 12, 2024 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
buildDuration 18.4s 28s ⚠️ +9.6s
buildDurationCached 14.8s 12.5s N/A
nodeModulesSize 410 MB 410 MB N/A
nextStartRea..uration (ms) 469ms 470ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
1187-HASH.js gzip 51.4 kB 50.9 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
index.html gzip 523 B 523 B ✓
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 204 kB 204 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
middleware-b..fest.js gzip 672 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
523-experime...dev.js gzip 322 B 322 B ✓
523.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 324 kB 323 kB N/A
app-page-exp..prod.js gzip 128 kB 127 kB N/A
app-page-tur..prod.js gzip 141 kB 140 kB N/A
app-page-tur..prod.js gzip 136 kB 135 kB N/A
app-page.run...dev.js gzip 314 kB 313 kB N/A
app-page.run..prod.js gzip 124 kB 123 kB N/A
app-route-ex...dev.js gzip 37.5 kB 37.4 kB N/A
app-route-ex..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.5 kB 25.5 kB N/A
app-route-tu..prod.js gzip 25.3 kB 25.3 kB N/A
app-route.ru...dev.js gzip 39.1 kB 39 kB N/A
app-route.ru..prod.js gzip 25.3 kB 25.3 kB N/A
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB N/A
pages.runtim...dev.js gzip 27.5 kB 27.4 kB N/A
pages.runtim..prod.js gzip 21.7 kB 21.7 kB N/A
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 31.6 kB 31.6 kB ✓
build cache
vercel/next.js canary vercel/next.js wbinnssmith/chunk-item-output-asset-references Change
0.pack gzip 2.08 MB 2.05 MB N/A
index.pack gzip 74.3 kB 73.5 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Diff for pages.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: a7f5d69

sokra
sokra reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/chunk-item-output-asset-references branch 4 times, most recently from a83ec6f to f0a44e2 Compare December 13, 2024 04:31
@wbinnssmith
Make ChunkItems reference only OutputAssets
5e73de0 
This:

- Changes `ChunkItem`’s `references` implementation to only allow items to reference `OutputAssets`
- Implements a default `references` that returns an empty set of output assets
- Updates logic for using these output assets in `make_chunk_group`
- [ ] Moves logic for using the inner module’s references into areas that need it
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/chunk-item-output-asset-references branch from ef84a43 to ef5df66 Compare December 13, 2024 21:36
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/chunk-item-output-asset-references branch from ef5df66 to 1b0f61b Compare December 13, 2024 21:37
@wbinnssmith wbinnssmith marked this pull request as ready for review December 13, 2024 21:48
@wbinnssmith Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/chunk-item-output-asset-references branch from 8d81afb to a7f5d69 Compare December 17, 2024 21:05
@wbinnssmith wbinnssmith merged commit 560923d into canary Dec 17, 2024
125 of 130 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/chunk-item-output-asset-references branch December 17, 2024 22:46
@github-actions github-actions bot added the locked label Jan 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra left review comments

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wbinnssmith @ijjk @sokra @mischnic