Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWC and React versions for 14-2-1 branch #73791

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

unstubbable
Copy link
Contributor

@unstubbable unstubbable commented Dec 11, 2024

  • installs React v18 instead of latest in tests
  • removes Next.js v15 references from lockfile
  • installs "current" native SWC binaries instead of latest

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Dec 11, 2024
Copy link
Contributor Author

Copy link

socket-security bot commented Dec 11, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

- installs React v18 instead of latest in tests
- removes Next.js v15 references from lockfile
- installs local native SWC binaries instead of latest
@unstubbable unstubbable force-pushed the hl/fix-swc-react-14-2-1 branch from 4c72a67 to 837b9a8 Compare December 11, 2024 10:40
@ijjk
Copy link
Member

ijjk commented Dec 11, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
buildDuration 15.7s 13.7s N/A
buildDurationCached 7.9s 6.8s N/A
nodeModulesSize 201 MB 201 MB N/A
nextStartRea..uration (ms) 401ms 406ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB N/A
5428.HASH.js gzip 181 B 180 B N/A
6067-HASH.js gzip 5.06 kB 5.06 kB N/A
6428-HASH.js gzip 31.6 kB 31.6 kB N/A
framework-HASH.js gzip 44.9 kB 44.9 kB
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.3 kB 32.3 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 44.9 kB 44.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 185 B N/A
amp-HASH.js gzip 502 B 504 B N/A
css-HASH.js gzip 321 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 258 B 257 B N/A
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 371 B 372 B N/A
image-HASH.js gzip 4.23 kB 4.23 kB N/A
index-HASH.js gzip 259 B 257 B N/A
link-HASH.js gzip 2.67 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 314 B N/A
script-HASH.js gzip 385 B 386 B N/A
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 654 B 654 B
Client Build Manifests
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
_buildManifest.js gzip 483 B 481 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
index.html gzip 527 B 527 B
link.html gzip 540 B 539 B N/A
withRouter.html gzip 521 B 523 B N/A
Overall change 527 B 527 B
Edge SSR bundle Size
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
edge-ssr.js gzip 95.5 kB 95.5 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
middleware-b..fest.js gzip 656 B 657 B N/A
middleware-r..fest.js gzip 156 B 154 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 839 B 839 B
Next Runtimes
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.3 kB 98.3 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 145 kB 145 kB
app-page.run..prod.js gzip 92.8 kB 92.8 kB
app-route-ex...dev.js gzip 22.5 kB 22.5 kB
app-route-ex..prod.js gzip 15.9 kB 15.9 kB
app-route-tu..prod.js gzip 15.9 kB 15.9 kB
app-route-tu..prod.js gzip 15.6 kB 15.6 kB
app-route.ru...dev.js gzip 22.2 kB 22.2 kB
app-route.ru..prod.js gzip 15.6 kB 15.6 kB
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.2 kB 23.2 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 959 kB 959 kB
build cache Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js hl/fix-swc-react-14-2-1 Change
0.pack gzip 1.63 MB 1.63 MB N/A
index.pack gzip 114 kB 114 kB ⚠️ +347 B
Overall change 114 kB 114 kB ⚠️ +347 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: 837b9a8

@ijjk
Copy link
Member

ijjk commented Dec 11, 2024

Tests Passed

@unstubbable unstubbable marked this pull request as ready for review December 11, 2024 12:57
@unstubbable unstubbable merged commit 663fa9c into 14-2-1 Dec 11, 2024
53 of 58 checks passed
@unstubbable unstubbable deleted the hl/fix-swc-react-14-2-1 branch December 11, 2024 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants