Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the example of with-unstated to utilize the App Router. #73211

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

PapatMayuri
Copy link
Contributor

@PapatMayuri PapatMayuri commented Nov 26, 2024

This PR updates the with-unstated example for using the App Router.
Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Added the layout.tsx file as part of the App Router.
  • Moved the components folder inside app folder.
  • Updated the package.json file.
  • Added hooks for counter and clock.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Nov 26, 2024
@ijjk
Copy link
Member

ijjk commented Nov 26, 2024

Allow CI Workflow Run

  • approve CI run for commit: dd59537

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Nov 26, 2024

Allow CI Workflow Run

  • approve CI run for commit: dd59537

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 26, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4de3f9a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@PapatMayuri PapatMayuri marked this pull request as ready for review November 26, 2024 13:50
@samcx samcx self-requested a review November 26, 2024 22:16
@samcx
Copy link
Member

samcx commented Nov 26, 2024

@PapatMayuri Moving forward with removing this example since this package hasn't been maintained in ~6 years.

@samcx samcx enabled auto-merge (squash) November 26, 2024 22:25
@samcx samcx merged commit 661f3fb into vercel:canary Nov 26, 2024
39 checks passed
wyattjoh pushed a commit that referenced this pull request Nov 28, 2024
This PR updates the with-unstated  example for using the App Router.
Here are the changes that have been made:

- Renamed the "pages" folder to the "app" folder.
- Added the layout.tsx file as part of the App Router.
- Moved the components folder inside app folder.
- Updated the package.json file.
- Added hooks for counter and clock.

    

CC: @samcx

---------

Co-authored-by: samcx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants