docs: Improve Accuracy and Type Safety on Data Fetching Examples #73122
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
hyungjikim
changed the title
ijjk
approved these changes
Nov 25, 2024
wyattjoh
pushed a commit
that referenced
this pull request
Nov 28, 2024
) Hi, Team. Updated Reusing data across multiple functions examples on data fetching documentation to improve type safety and accuracy. ### Summary of Changes 1. Added Async Params 2. Fixed Dynamic Route Example Path - Corrected the path structure for dynamic routes to reflect actual usage as `app/page.tsx` cannot be used to access dynamic routed paths. 3. Improved Type Safety in `generateStaticParams` - Type mismatch: `generateStaticParams` expects string parameter, but examples used `post.id` which of type is number, causing both build time and client run time failures. <img width="1109" alt="image" src="https://github.com/user-attachments/assets/ae6fad44-0b7f-4aac-ac31-74a6581c995b"> <img width="714" alt="image" src="https://github.com/user-attachments/assets/d8fb19c9-9dd1-4e6a-8d2b-b25f719e3742"> 4. Replaced let variable with const variable - Prevent accidental reassignment as it is not needed --------- Co-authored-by: JJ Kasper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Team.
Updated Reusing data across multiple functions examples on data fetching documentation to improve type safety and accuracy.
Summary of Changes
Added Async Params
Fixed Dynamic Route Example Path
app/page.tsxcannot be used to access dynamic routed paths.generateStaticParamsgenerateStaticParamsexpects string parameter, but examples usedpost.idwhich of type is number, causing both build time and client run time failures.