Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): add example for image optimization with secure compute #72641

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 12, 2024

This PR adds a new example that shows a more complex use case where you don't want browser to know about the upstream image server so instead you can proxy through a serverless function.

Some use cases might be checking for an IP address, user agent, etc.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples labels Nov 12, 2024
@styfle styfle requested review from a team November 12, 2024 23:55
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add react and react-dom dependencies as well?

@styfle
Copy link
Member Author

styfle commented Nov 13, 2024

@samcx Sounds good, added 👍

@styfle styfle requested a review from samcx November 13, 2024 13:53
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lfgtm-intense:

@styfle styfle merged commit aaf28ab into canary Nov 13, 2024
52 checks passed
@styfle styfle deleted the styfle/example-img-secure-comp branch November 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants