feat: bump sass-loader #72202
Closed
feat: bump sass-loader #72202
+45
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
|
Thanks for the PR! Though as it requires a major version bump for sass-loader, we are adding an experimental option at #72423. Not 100% sure about the docs change, but the removal of Closing as superseded by #72423. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bump sass-loader to v16, which switches the legacy Sass JS API to the modern API (This is a breaking change, as some sass options got renamed, deprecated, etc)
Got rid of the
fibersoption, as this was only for node <14, while Next now requires at least node 18.And moved some docs around which made more sense I think
Why?
To get rid of the deprecation warnings
Sass team; #67931
Next 15 issue; #71638