Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Turbopack] update total size when reached #71354

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 16, 2024

What?

When loading a trace file and that increases in size while reading it, update the info about the total size before reaching 100%.

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Oct 16, 2024
Copy link
Member Author

sokra commented Oct 16, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sokra and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Oct 16, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 16, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
buildDuration 32.8s 33.3s ⚠️ +461ms
buildDurationCached 29s 24.3s N/A
nodeModulesSize 372 MB 372 MB N/A
nextStartRea..uration (ms) 794ms 807ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
307bebc6-HASH.js gzip 52.6 kB 52.6 kB N/A
3620-HASH.js gzip 43.9 kB 43.9 kB N/A
801.HASH.js gzip 168 B 169 B N/A
8962-HASH.js gzip 5.26 kB 5.26 kB N/A
framework-HASH.js gzip 57.4 kB 57.4 kB N/A
main-app-HASH.js gzip 230 B 230 B
main-HASH.js gzip 32.8 kB 32.8 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 230 B 230 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
_app-HASH.js gzip 192 B 192 B
_error-HASH.js gzip 193 B 192 B N/A
amp-HASH.js gzip 509 B 509 B
css-HASH.js gzip 341 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 266 B 266 B
head-HASH.js gzip 365 B 364 B N/A
hooks-HASH.js gzip 392 B 391 B N/A
image-HASH.js gzip 4.41 kB 4.41 kB N/A
index-HASH.js gzip 267 B 268 B N/A
link-HASH.js gzip 2.78 kB 2.78 kB N/A
routerDirect..HASH.js gzip 327 B 327 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 324 B 322 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.64 kB 3.64 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
_buildManifest.js gzip 748 B 750 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
index.html gzip 521 B 524 B N/A
link.html gzip 536 B 538 B N/A
withRouter.html gzip 518 B 519 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 189 kB 189 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
middleware-b..fest.js gzip 671 B 670 B N/A
middleware-r..fest.js gzip 154 B 156 B N/A
middleware.js gzip 31 kB 30.8 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
973-experime...dev.js gzip 322 B 322 B
973.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 314 kB 314 kB N/A
app-page-exp..prod.js gzip 121 kB 121 kB N/A
app-page-tur..prod.js gzip 134 kB 134 kB N/A
app-page-tur..prod.js gzip 129 kB 129 kB N/A
app-page.run...dev.js gzip 305 kB 305 kB N/A
app-page.run..prod.js gzip 116 kB 116 kB N/A
app-route-ex...dev.js gzip 35.5 kB 35.5 kB
app-route-ex..prod.js gzip 24.1 kB 24.1 kB
app-route-tu..prod.js gzip 24.1 kB 24.1 kB
app-route-tu..prod.js gzip 23.9 kB 23.9 kB
app-route.ru...dev.js gzip 37.1 kB 37.1 kB
app-route.ru..prod.js gzip 23.9 kB 23.9 kB
pages-api-tu..prod.js gzip 9.61 kB 9.61 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.61 kB 9.61 kB
pages-turbo...prod.js gzip 20.9 kB 20.9 kB
pages.runtim...dev.js gzip 26.5 kB 26.5 kB
pages.runtim..prod.js gzip 20.9 kB 20.9 kB
server.runti..prod.js gzip 60.2 kB 60.2 kB N/A
Overall change 268 kB 268 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/tracing-total-size Change
0.pack gzip 1.84 MB 1.84 MB ⚠️ +2.55 kB
index.pack gzip 144 kB 144 kB ⚠️ +479 B
Overall change 1.99 MB 1.99 MB ⚠️ +3.03 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for image-HASH.js
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [8358],
   {
-    /***/ 6441: /***/ (
+    /***/ 7486: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/image",
         function () {
-          return __webpack_require__(2563);
+          return __webpack_require__(5412);
         },
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 6730: /***/ (module, exports, __webpack_require__) => {
+    /***/ 9569: /***/ (module, exports, __webpack_require__) => {
       "use strict";
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
@@ -40,17 +40,17 @@
         __webpack_require__(38)
       );
       const _head = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(8624)
+        __webpack_require__(7269)
       );
-      const _getimgprops = __webpack_require__(2990);
-      const _imageconfig = __webpack_require__(876);
-      const _imageconfigcontextsharedruntime = __webpack_require__(2767);
-      const _warnonce = __webpack_require__(5064);
-      const _routercontextsharedruntime = __webpack_require__(3948);
+      const _getimgprops = __webpack_require__(6985);
+      const _imageconfig = __webpack_require__(8151);
+      const _imageconfigcontextsharedruntime = __webpack_require__(8836);
+      const _warnonce = __webpack_require__(9138);
+      const _routercontextsharedruntime = __webpack_require__(4654);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(5825)
+        __webpack_require__(2946)
       );
-      const _usemergedref = __webpack_require__(6956);
+      const _usemergedref = __webpack_require__(5658);
       // This is replaced by webpack define plugin
       const configEnv = {
         deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
       /***/
     },
 
-    /***/ 6956: /***/ (module, exports, __webpack_require__) => {
+    /***/ 5658: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -432,7 +432,7 @@
       /***/
     },
 
-    /***/ 2990: /***/ (
+    /***/ 6985: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -448,9 +448,9 @@
           return getImgProps;
         },
       });
-      const _warnonce = __webpack_require__(5064);
-      const _imageblursvg = __webpack_require__(2243);
-      const _imageconfig = __webpack_require__(876);
+      const _warnonce = __webpack_require__(9138);
+      const _imageblursvg = __webpack_require__(4901);
+      const _imageconfig = __webpack_require__(8151);
       const VALID_LOADING_VALUES =
         /* unused pure expression or super */ null && [
           "lazy",
@@ -823,7 +823,7 @@
       /***/
     },
 
-    /***/ 2243: /***/ (__unused_webpack_module, exports) => {
+    /***/ 4901: /***/ (__unused_webpack_module, exports) => {
       "use strict";
       /**
        * A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -878,7 +878,7 @@
       /***/
     },
 
-    /***/ 2470: /***/ (
+    /***/ 5731: /***/ (
       __unused_webpack_module,
       exports,
       __webpack_require__
@@ -905,10 +905,10 @@
         },
       });
       const _interop_require_default = __webpack_require__(9608);
-      const _getimgprops = __webpack_require__(2990);
-      const _imagecomponent = __webpack_require__(6730);
+      const _getimgprops = __webpack_require__(6985);
+      const _imagecomponent = __webpack_require__(9569);
       const _imageloader = /*#__PURE__*/ _interop_require_default._(
-        __webpack_require__(5825)
+        __webpack_require__(2946)
       );
       function getImageProps(imgProps) {
         const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -940,7 +940,7 @@
       /***/
     },
 
-    /***/ 5825: /***/ (__unused_webpack_module, exports) => {
+    /***/ 2946: /***/ (__unused_webpack_module, exports) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -975,7 +975,7 @@
       /***/
     },
 
-    /***/ 2563: /***/ (
+    /***/ 5412: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -992,8 +992,8 @@
 
       // EXTERNAL MODULE: ./node_modules/.pnpm/[email protected]/node_modules/react/jsx-runtime.js
       var jsx_runtime = __webpack_require__(7125);
-      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-cd22717c-20241013_re_a5fwrzcgiqxq7kbo7kpyzjc5ji/node_modules/next/image.js
-      var next_image = __webpack_require__(9983);
+      // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-cd22717c-20241013_re_zq6nvqen5pqfmm5xeouxrlc4aq/node_modules/next/image.js
+      var next_image = __webpack_require__(9231);
       var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
       /* harmony default export */ const nextjs = {
         src: "/_next/static/media/nextjs.cae0b805.png",
@@ -1023,12 +1023,12 @@
       /***/
     },
 
-    /***/ 9983: /***/ (
+    /***/ 9231: /***/ (
       module,
       __unused_webpack_exports,
       __webpack_require__
     ) => {
-      module.exports = __webpack_require__(2470);
+      module.exports = __webpack_require__(5731);
 
       /***/
     },
@@ -1038,7 +1038,7 @@
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
     /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
-      __webpack_exec__(6441)
+      __webpack_exec__(7486)
     );
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for link-HASH.js
@@ -1,7 +1,7 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [4644],
   {
-    /***/ 6707: /***/ (
+    /***/ 9202: /***/ (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
@@ -9,7 +9,7 @@
       (window.__NEXT_P = window.__NEXT_P || []).push([
         "/link",
         function () {
-          return __webpack_require__(940);
+          return __webpack_require__(2971);
         },
       ]);
       if (false) {
@@ -18,7 +18,7 @@
       /***/
     },
 
-    /***/ 2387: /***/ (module, exports) => {
+    /***/ 8382: /***/ (module, exports) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -96,7 +96,7 @@
       /***/
     },
 
-    /***/ 3025: /***/ (module, exports, __webpack_require__) => {
+    /***/ 1205: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -108,7 +108,7 @@
           return getDomainLocale;
         },
       });
-      const _normalizetrailingslash = __webpack_require__(5747);
+      const _normalizetrailingslash = __webpack_require__(3250);
       const basePath =
         /* unused pure expression or super */ null && (false || "");
       function getDomainLocale(path, locale, locales, domainLocales) {
@@ -132,7 +132,7 @@
       /***/
     },
 
-    /***/ 2051: /***/ (module, exports, __webpack_require__) => {
+    /***/ 3836: /***/ (module, exports, __webpack_require__) => {
       "use strict";
       /* __next_internal_client_entry_do_not_use__  cjs */
       Object.defineProperty(exports, "__esModule", {
@@ -149,18 +149,18 @@
       const _react = /*#__PURE__*/ _interop_require_default._(
         __webpack_require__(1299)
       );
-      const _resolvehref = __webpack_require__(3994);
-      const _islocalurl = __webpack_require__(9486);
-      const _formaturl = __webpack_require__(3261);
-      const _utils = __webpack_require__(2625);
-      const _addlocale = __webpack_require__(4546);
-      const _routercontextsharedruntime = __webpack_require__(3948);
-      const _approutercontextsharedruntime = __webpack_require__(9855);
-      const _useintersection = __webpack_require__(2280);
-      const _getdomainlocale = __webpack_require__(3025);
-      const _addbasepath = __webpack_require__(5594);
-      const _routerreducertypes = __webpack_require__(2387);
-      const _usemergedref = __webpack_require__(6956);
+      const _resolvehref = __webpack_require__(8216);
+      const _islocalurl = __webpack_require__(1998);
+      const _formaturl = __webpack_require__(6261);
+      const _utils = __webpack_require__(5528);
+      const _addlocale = __webpack_require__(3774);
+      const _routercontextsharedruntime = __webpack_require__(4654);
+      const _approutercontextsharedruntime = __webpack_require__(92);
+      const _useintersection = __webpack_require__(4930);
+      const _getdomainlocale = __webpack_require__(1205);
+      const _addbasepath = __webpack_require__(7254);
+      const _routerreducertypes = __webpack_require__(8382);
+      const _usemergedref = __webpack_require__(5658);
       const prefetched = new Set();
       function prefetch(router, href, as, options, appOptions, isAppRouter) {
         if (false) {
@@ -588,7 +588,7 @@
       /***/
     },
 
-    /***/ 2280: /***/ (module, exports, __webpack_require__) => {
+    /***/ 4930: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -601,7 +601,7 @@
         },
       });
       const _react = __webpack_require__(1299);
-      const _requestidlecallback = __webpack_require__(8162);
+      const _requestidlecallback = __webpack_require__(7242);
       const hasIntersectionObserver =
         typeof IntersectionObserver === "function";
       const observers = new Map();
@@ -714,7 +714,7 @@
       /***/
     },
 
-    /***/ 6956: /***/ (module, exports, __webpack_require__) => {
+    /***/ 5658: /***/ (module, exports, __webpack_require__) => {
       "use strict";
 
       Object.defineProperty(exports, "__esModule", {
@@ -775,7 +775,7 @@
       /***/
     },
 
-    /***/ 940: /***/ (
+    /***/ 2971: /***/ (
       __unused_webpack_module,
       __webpack_exports__,
       __webpack_require__
@@ -790,7 +790,7 @@
       /* harmony import */ var react_jsx_runtime__WEBPACK_IMPORTED_MODULE_0__ =
         __webpack_require__(7125);
       /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1__ =
-        __webpack_require__(20);
+        __webpack_require__(2778);
       /* harmony import */ var next_link__WEBPACK_IMPORTED_MODULE_1___default =
         /*#__PURE__*/ __webpack_require__.n(
           next_link__WEBPACK_IMPORTED_MODULE_1__
@@ -821,8 +821,12 @@
       /***/
     },
 
-    /***/ 20: /***/ (module, __unused_webpack_exports, __webpack_require__) => {
-      module.exports = __webpack_require__(2051);
+    /***/ 2778: /***/ (
+      module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) => {
+      module.exports = __webpack_require__(3836);
 
       /***/
     },
@@ -832,7 +836,7 @@
     /******/ var __webpack_exec__ = (moduleId) =>
       __webpack_require__((__webpack_require__.s = moduleId));
     /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
-      __webpack_exec__(6707)
+      __webpack_exec__(9202)
     );
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Diff for 3620-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: bffead8

@sokra sokra changed the title update total size when reached [Turbopack] update total size when reached Oct 18, 2024
@sokra sokra requested a review from timneutkens October 18, 2024 11:02
@sokra sokra marked this pull request as ready for review October 18, 2024 11:02
@timneutkens timneutkens merged commit c82f8e6 into canary Oct 18, 2024
109 checks passed
@timneutkens timneutkens deleted the sokra/tracing-total-size branch October 18, 2024 13:28
samcx pushed a commit that referenced this pull request Oct 18, 2024
### What?

When loading a trace file and that increases in size while reading it,
update the info about the total size before reaching 100%.
@github-actions github-actions bot added the locked label Nov 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants