Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(route-groups): add an example about opting loading skeletons to a specific route #71328

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

samcx
Copy link
Member

@samcx samcx commented Oct 15, 2024

Why?

Add an additional example that highlights using Route Groups to opt a loading skeleton to a specific route.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels Oct 15, 2024
Copy link
Member Author

samcx commented Oct 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @samcx and the rest of your teammates on Graphite Graphite

@samcx samcx requested a review from ijjk October 15, 2024 22:22
@samcx samcx marked this pull request as ready for review October 15, 2024 22:23
@samcx samcx requested a review from ijjk October 15, 2024 23:00
@gmoniava
Copy link

gmoniava commented Oct 16, 2024

To create a loading skeleton via a loading.js file for a specific route, create a new route group (e.g., /(overview)) and then move your loading.tsx inside that route group

This explanation is not clear. You can already create loading skeleton via loading.js for a specific route - this explanation does not explain what route groups add to that. It should elaborate in which situations is combination of route groups and loading.js files useful.

@samcx @ijjk

@samcx samcx requested a review from ijjk October 17, 2024 04:27
@samcx samcx force-pushed the sam/docs/route-groups-loading branch from d23791a to f26785a Compare October 17, 2024 17:06
@samcx samcx requested a review from gmoniava October 17, 2024 19:26
Copy link
Contributor

github-actions bot commented Oct 17, 2024

All broken links are now fixed, thank you!

Copy link

@gmoniava gmoniava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment to ztanner.

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue was opened via the examples template. tests Turbopack Related to Turbopack with Next.js. type: next labels Oct 18, 2024
@samcx samcx added created-by: Next.js team PRs by the Next.js team. and removed examples Issue was opened via the examples template. type: next create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. Turbopack Related to Turbopack with Next.js. tests labels Oct 18, 2024
@samcx
Copy link
Member Author

samcx commented Oct 18, 2024

My gosh Graphite :coffin_dance:

@samcx samcx force-pushed the sam/docs/route-groups-loading branch from b4eb882 to c8919f9 Compare October 18, 2024 13:48
@samcx samcx force-pushed the sam/docs/route-groups-loading branch from 8f96996 to 1b838fc Compare October 18, 2024 13:55
@samcx samcx requested review from ztanner, ijjk and gmoniava October 18, 2024 14:44
@samcx samcx merged commit bf3755d into canary Oct 18, 2024
51 checks passed
@samcx samcx deleted the sam/docs/route-groups-loading branch October 18, 2024 19:57
@github-actions github-actions bot added the locked label Nov 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Missing documentation about route groups and loading page behavior
4 participants