Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React from 2d16326d-20240930 to 70fb1363-20241010 #71118

Merged
merged 9 commits into from
Oct 11, 2024
Merged

Upgrade React from 2d16326d-20240930 to 70fb1363-20241010 #71118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9724ac6
Don't warn on well-known properties in `searchParams`
eps1lon Oct 11, 2024
7e786d4
Update `react@experimental`
vercel-release-bot Oct 10, 2024
7ac77c5
Update `react@rc`
vercel-release-bot Oct 10, 2024
d14886b
Updated peer dependency references
vercel-release-bot Oct 10, 2024
113383d
Update lockfile
vercel-release-bot Oct 10, 2024
b04ed62
ncc-compiled
vercel-release-bot Oct 10, 2024
1eef6cb
Adjust tests to ignore serialized RSC props
eps1lon Oct 11, 2024
5ea8168
Update tests asserting on internal stackframes
eps1lon Oct 11, 2024
30b2a13
Adjust otel tests for increased `clientComponentLoadCount`
eps1lon Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/app-dir/rsc-basic/app/css-in-js/suspense/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function page() {
<div>
<Footer id="footer">
{`wait for `}
<Suspense fallback={`fallback`}>
<Suspense fallback={`$test-fallback-sentinel`}>
<SuspenseyFooter />
</Suspense>
</Footer>
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/rsc-basic/rsc-basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ describe('app dir - rsc basics', () => {
const hasRCScript = /\$RC=function/.test(chunk)
if (hasRCScript) results.push('refresh-script')

const isFallbackResolved = chunk.includes('fallback')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallback now matches Next.js source that was sent as debugging info. Specifically, const fallbackParams

const isFallbackResolved = chunk.includes('$test-fallback-sentinel')
if (isFallbackResolved) results.push('fallback')
})

Expand Down
Loading