Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not invoke server actions twice when dynamicIO is enabled #70784

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Do not invoke server actions twice when dynamicIO is enabled #70784

merged 2 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Do not invoke server actions twice when dynamicIO is enabled 

    In dev mode, when dynamic IO is enabled, we seed a prefetch cache scope
for non-prefetch requests (via #70408).

We must omit server action requests from this cache seeding though,
because it would lead to the action handler being called twice. This is
not intended in general for any action, and specificially fails in the
second invocation while decoding the request form data with `Error:
Unexpected end of JSON input` in `initializeModelChunk`, because the
request body was already consumed in the first invocation.
    @unstubbable
    unstubbable committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    570aaf4 View commit details
    Browse the repository at this point in the history

  2. Move new test into existing dynamic-io test app

    @unstubbable
    unstubbable committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7201f49 View commit details
    Browse the repository at this point in the history