Update reactStrictMode.mdx enabled since 13.5.1 #70557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
1 similar comment
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
fix 70559 |
abhi12299
pushed a commit
to abhi12299/next.js
that referenced
this pull request
Sep 29, 2024
Spent over 2 hours checking why with 13.4.19 components didn't mount twice as the docs says "Good to know: Since Next.js 13.4, Strict Mode is true by default with app router". But it's enabled by default in [13.5.1](https://github.com/vercel/next.js/releases/tag/v13.5.1). Version [13.5.0](https://github.com/vercel/next.js/releases/tag/v13.5.0) has no changelog? Maybe reactStrictMode it's enabled by default since 13.5.0 instead 13.5.1 ? Fixes: vercel#70559 Co-authored-by: JJ Kasper <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spent over 2 hours checking why with 13.4.19 components didn't mount twice as the docs says "Good to know: Since Next.js 13.4, Strict Mode is true by default with app router".
But it's enabled by default in 13.5.1.
Version 13.5.0 has no changelog?
Maybe reactStrictMode it's enabled by default since 13.5.0 instead 13.5.1 ?
Fixes: #70559