Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the example of modularize-imports to utilize the App Router #69771

Merged

Conversation

Sam-Phillemon9493
Copy link
Contributor

@Sam-Phillemon9493 Sam-Phillemon9493 commented Sep 6, 2024

This PR updates the modularize-imports example to use the App Router. Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Updated the routing for / files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Sep 6, 2024
@ijjk
Copy link
Member

ijjk commented Sep 6, 2024

Allow CI Workflow Run

  • approve CI run for commit: 3c1ac13

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@Sam-Phillemon9493 Sam-Phillemon9493 marked this pull request as ready for review September 6, 2024 03:37
@samcx
Copy link
Member

samcx commented Sep 6, 2024

@Sam-Phillemon9493 This config is no longer relevant as of v13.5 and greater → https://nextjs.org/docs/architecture/nextjs-compiler#modularize-imports

Let's just go ahead and remove this example.

@Sam-Phillemon9493
Copy link
Contributor Author

@Sam-Phillemon9493 This config is no longer relevant as of v13.5 and greater → https://nextjs.org/docs/architecture/nextjs-compiler#modularize-imports

Let's just go ahead and remove this example.

@samcx Thanks for pointing that out! I’ve removed the outdated example. Let me know if there’s anything else to update!

@samcx samcx added the CI approved Approve running CI for fork label Sep 9, 2024
@samcx samcx merged commit f3c537b into vercel:canary Sep 9, 2024
38 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants