Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Backport Multi-Zones docs to 14.x branch #68460

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mknichel
Copy link
Member

@mknichel mknichel commented Aug 2, 2024

This makes the Multi-Zones docs available in the live nextjs.org site.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Aug 2, 2024
@ijjk
Copy link
Member

ijjk commented Aug 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: cbcdbe7

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@mknichel mknichel marked this pull request as ready for review August 2, 2024 18:51
@mknichel mknichel requested review from a team as code owners August 2, 2024 18:51
@mknichel mknichel requested review from anthonyshew and nicoalbanese and removed request for a team August 2, 2024 18:51
@ijjk
Copy link
Member

ijjk commented Aug 2, 2024

Failing test suites

Commit: cbcdbe7

pnpm test test/integration/app-dir-export/test/dynamicpage-prod.test.ts

  • app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicPage 'force-static'
Expand output

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicPage 'force-static'

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  14 |             'Page with `dynamic = "force-dynamic"` couldn\'t be exported. `output: "export"` requires all pages be renderable statically',
  15 |         },
> 16 |       ])(
     |        ^
  17 |         'should work in prod with dynamicPage $dynamicPage',
  18 |         async ({ dynamicPage, expectedErrMsg }) => {
  19 |           await runTests({ isDev: false, dynamicPage, expectedErrMsg })

  at ../node_modules/.pnpm/[email protected]/node_modules/jest-each/build/bind.js:47:15
      at Array.forEach (<anonymous>)
  at integration/app-dir-export/test/dynamicpage-prod.test.ts:16:8
  at integration/app-dir-export/test/dynamicpage-prod.test.ts:4:56
  at Object.describe (integration/app-dir-export/test/dynamicpage-prod.test.ts:3:1)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit 28110b6 into 14-2-1 Aug 2, 2024
68 of 75 checks passed
@ijjk ijjk deleted the mknichel/backport-multi-zones-docs branch August 2, 2024 19:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants