You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only log route requests and related fetch calls.
Before/After:
Why?
#62946 introduced logging some request information by default, but it is too verbose, logging even requests that are unlikely useful to the user (ie.: _rsc, static asset requests when Middleware is present, etc.)
How?
We have some meta information on requests so we can identify if a request belongs to a route so we can terminate logging early.
The reason will be displayed to describe this comment to others. Learn more.
didInvokePath is not present anywhere in the codebase, likely a remainder of some other code that hasn't been cleaned up properly. (Not using as any here should have caught this.)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We should only log route requests and related
fetch
calls.Before/After:
Why?
#62946 introduced logging some request information by default, but it is too verbose, logging even requests that are unlikely useful to the user (ie.: _rsc, static asset requests when Middleware is present, etc.)
How?
We have some meta information on requests so we can identify if a request belongs to a route so we can terminate logging early.
Closes NEXT-2977, closes NEXT-2954