-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak prefetched argument to router cache utils #61177
Merged
ztanner
merged 2 commits into
01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer
from
01-25-tweak_prefetched_argument_to_router_cache_utils
Jan 31, 2024
Merged
tweak prefetched argument to router cache utils #61177
ztanner
merged 2 commits into
01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer
from
01-25-tweak_prefetched_argument_to_router_cache_utils
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for 68-HASH.jsDiff too large to display |
ztanner
force-pushed
the
01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer
branch
from
January 26, 2024 21:49
1dd7fd5
to
02dcaa7
Compare
ztanner
force-pushed
the
01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer
branch
3 times, most recently
from
January 27, 2024 18:05
e50ec2c
to
85ef571
Compare
ztanner
force-pushed
the
01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer
branch
from
January 30, 2024 22:11
85ef571
to
8fbf043
Compare
ztanner
force-pushed
the
01-25-tweak_prefetched_argument_to_router_cache_utils
branch
from
January 30, 2024 22:11
17cd069
to
9f2c41f
Compare
Tests Passed |
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim and
wyattjoh
as code owners
January 30, 2024 23:20
ijjk
approved these changes
Jan 31, 2024
ztanner
force-pushed
the
01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer
branch
2 times, most recently
from
January 31, 2024 17:38
50b00d3
to
41b35f3
Compare
ztanner
merged commit Jan 31, 2024
5d793e8
into
01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer
120 of 123 checks passed
ztanner
deleted the
01-25-tweak_prefetched_argument_to_router_cache_utils
branch
January 31, 2024 20:17
This was referenced Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No behavior changes here, purely renaming this argument as I found it confusing while working on a router cache bug. It's not strictly representing if a cache node was prefetched, but rather if the prefetch entry exists & can be re-used, since it could be that it was prefetched but had a prefetch status of stale/expired.
Closes NEXT-2245