Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak prefetched argument to router cache utils #61177

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Jan 26, 2024

No behavior changes here, purely renaming this argument as I found it confusing while working on a router cache bug. It's not strictly representing if a cache node was prefetched, but rather if the prefetch entry exists & can be re-used, since it could be that it was prefetched but had a prefetch status of stale/expired.

Closes NEXT-2245

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 26, 2024
@ijjk
Copy link
Member

ijjk commented Jan 26, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
buildDuration 11.9s 12s ⚠️ +146ms
buildDurationCached 6.4s 5.3s N/A
nodeModulesSize 200 MB 200 MB N/A
nextStartRea..uration (ms) 439ms 429ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.9 kB 29.9 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
index.html gzip 528 B 526 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 522 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
edge-ssr.js gzip 94 kB 94.1 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
middleware-b..fest.js gzip 623 B 622 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js 01-25-tweak_prefetched_argument_to_router_cache_utils Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Diff details
Diff for page.js

Diff too large to display

Diff for 68-HASH.js

Diff too large to display

Commit: 9f2c41f

@ztanner ztanner force-pushed the 01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer branch from 1dd7fd5 to 02dcaa7 Compare January 26, 2024 21:49
@ztanner ztanner force-pushed the 01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer branch 3 times, most recently from e50ec2c to 85ef571 Compare January 27, 2024 18:05
@ztanner ztanner force-pushed the 01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer branch from 85ef571 to 8fbf043 Compare January 30, 2024 22:11
@ztanner ztanner force-pushed the 01-25-tweak_prefetched_argument_to_router_cache_utils branch from 17cd069 to 9f2c41f Compare January 30, 2024 22:11
@ijjk
Copy link
Member

ijjk commented Jan 30, 2024

Tests Passed

@ztanner ztanner marked this pull request as ready for review January 30, 2024 23:20
@ztanner ztanner force-pushed the 01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer branch 2 times, most recently from 50b00d3 to 41b35f3 Compare January 31, 2024 17:38
@ztanner ztanner merged commit 5d793e8 into 01-25-remove_unnecessary_PPR_branch_in_non-PPR_reducer Jan 31, 2024
120 of 123 checks passed
@ztanner ztanner deleted the 01-25-tweak_prefetched_argument_to_router_cache_utils branch January 31, 2024 20:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants