Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(example): update storybook #60737

Merged
merged 2 commits into from
Jan 17, 2024
Merged

chore(example): update storybook #60737

merged 2 commits into from
Jan 17, 2024

Conversation

AugustinMauroy
Copy link
Contributor

What?

  • update storybook version
  • use SWC for perf
  • pinging dep for security of the example
  • update readme to have correct link

@AugustinMauroy AugustinMauroy requested review from a team as code owners January 16, 2024 20:57
@AugustinMauroy AugustinMauroy requested review from manovotny and lydiahallie and removed request for a team January 16, 2024 20:57
@ijjk ijjk added the examples Issue was opened via the examples template. label Jan 16, 2024
@ijjk
Copy link
Member

ijjk commented Jan 17, 2024

Allow CI Workflow Run

  • approve CI run for commit: 8a02c75

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

samcx
samcx approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx samcx merged commit c028271 into vercel:canary Jan 17, 2024
30 checks passed
@AugustinMauroy AugustinMauroy deleted the storybook branch January 17, 2024 08:11
@vordgi vordgi mentioned this pull request Jan 21, 2024
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samcx samcx samcx approved these changes

@manovotny manovotny Awaiting requested review from manovotny manovotny was automatically assigned from vercel/devex

@lydiahallie lydiahallie Awaiting requested review from lydiahallie lydiahallie was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AugustinMauroy @ijjk @samcx