Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glob package in eslint-plugin-next #60651

Closed
wants to merge 1 commit into from

Conversation

k725
Copy link

@k725 k725 commented Jan 15, 2024

This is an update for a package that contains a vulnerability reported by Snyk.

https://security.snyk.io/package/npm/inflight/1.0.6

inflight has been abandoned and the latest version of the glob package does not depend on inflight.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
glob 10.3.10 None +0 454 kB isaacs

@styfle styfle added the CI approved Approve running CI for fork label Jan 16, 2024
@ijjk
Copy link
Member

ijjk commented Jan 16, 2024

Stats from current PR

Default Build
General
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
buildDuration 13s 13s N/A
buildDurationCached 7.1s 6.2s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 433ms 435ms N/A
Client Bundles (main, webpack)
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
433-HASH.js gzip 28.9 kB 28.9 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
index.html gzip 528 B 528 B
link.html gzip 540 B 540 B
withRouter.html gzip 522 B 524 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
edge-ssr.js gzip 93.9 kB 93.9 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
middleware-b..fest.js gzip 621 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary rbjb/next.js upgrade-eslint-plugin-glob Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 95.3 kB 95.3 kB
app-page-tur..prod.js gzip 96 kB 96 kB
app-page-tur..prod.js gzip 90.5 kB 90.5 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 89.9 kB 89.9 kB
app-route-ex...dev.js gzip 24.1 kB 24.1 kB
app-route-ex..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.8 kB 16.8 kB
app-route-tu..prod.js gzip 16.3 kB 16.3 kB
app-route.ru...dev.js gzip 23.5 kB 23.5 kB
app-route.ru..prod.js gzip 16.3 kB 16.3 kB
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.6 kB 49.6 kB
Overall change 941 kB 941 kB
Commit: ac753b8

@ijjk
Copy link
Member

ijjk commented Jan 16, 2024

Failing test suites

Commit: ac753b8

pnpm test test/integration/edge-runtime-module-errors/test/module-imports.test.js

  • Edge runtime code with imports > Edge API statically importing node.js module > throws unsupported module error in dev at runtime and highlights the faulty line
Expand output

● Edge runtime code with imports › Edge API statically importing node.js module › throws unsupported module error in dev at runtime and highlights the faulty line

expect(received).toBe(expected) // Object.is equality

Expected: 500
Received: 404

  86 |       context.app = await launchApp(context.appDir, context.appPort, appOption)
  87 |       const res = await fetchViaHTTP(context.appPort, url)
> 88 |       expect(res.status).toBe(500)
     |                          ^
  89 |       await check(async () => {
  90 |         expectUnsupportedModuleDevError(
  91 |           moduleName,

  at Object.toBe (integration/edge-runtime-module-errors/test/module-imports.test.js:88:26)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/rsc-runtime-errors.test.ts

  • Error overlay - RSC runtime errors > should show runtime errors if invalid client API from node_modules is executed
  • Error overlay - RSC runtime errors > should show runtime errors if invalid server API from node_modules is executed
  • Error overlay - RSC runtime errors > should show source code for jsx errors from server component
  • Error overlay - RSC runtime errors > should show the userland code error trace when fetch failed error occurred
Expand output

● Error overlay - RSC runtime errors › should show runtime errors if invalid client API from node_modules is executed

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Error overlay - RSC runtime errors › should show runtime errors if invalid server API from node_modules is executed

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Error overlay - RSC runtime errors › should show source code for jsx errors from server component

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Error overlay - RSC runtime errors › should show the userland code error trace when fetch failed error occurred

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:12:19)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  115 |
  116 | if (typeof afterAll === 'function') {
> 117 |   afterAll(async () => {
      |   ^
  118 |     if (nextInstance) {
  119 |       await nextInstance.destroy()
  120 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:117:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:7:19)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk removed the CI approved Approve running CI for fork label Jan 16, 2024
@ijjk ijjk closed this in #60732 Jan 16, 2024
ijjk pushed a commit that referenced this pull request Jan 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants