Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid next version tag name in with-cypress example #59647

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

icyJoseph
Copy link
Contributor

@icyJoseph icyJoseph commented Dec 15, 2023

Hi,

Fix for the accidental change, introduced in this PR #59572, which set the next version tag for the with-cypress example, to ^latest, which causes the create-next-app step to fail:

npx create-next-app --example with-cypress with-cypress-app
Creating a new Next.js app in /Users/<user>/<Project-Path>/with-cypress-app.

Downloading files for example with-cypress. This might take a moment.

Installing packages. This might take a couple of minutes.

npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name "^latest" of package "next@^latest": Tags may not have any characters that encodeURIComponent encodes.

Yarn instead, shows a list of next.js packages to select from instead.

@icyJoseph icyJoseph requested review from a team as code owners December 15, 2023 08:56
@icyJoseph icyJoseph requested review from molebox and StephDietz and removed request for a team December 15, 2023 08:56
@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 15, 2023
@ijjk
Copy link
Member

ijjk commented Dec 15, 2023

Allow CI Workflow Run

  • approve CI run for commit: f4529b9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Dec 15, 2023

Allow CI Workflow Run

  • approve CI run for commit: f4529b9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Dec 15, 2023

Allow CI Workflow Run

  • approve CI run for commit: dec36bb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk merged commit 7eac1c8 into vercel:canary Dec 18, 2023
32 checks passed
@github-actions github-actions bot added the locked label Jan 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants