Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish logging segments of page route #57834

Merged
merged 6 commits into from
Nov 1, 2023
Merged

Polish logging segments of page route #57834

merged 6 commits into from
Nov 1, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 31, 2023

Reduce the confusiong of the the logging of pages, make it easier to understand

  • Removing the trailing /page, /route suffix
  • Removing the internal segment like [[...__metadata__]]

After

 ○ Compiling / ...
 ○ Compiling /dynamic/[slug]/icon ...

Before

 ○ Compiling /page ...
 ○ Compiling /(group)/dynamic/[slug]/icon-ahg52g/[[...__metadata_id__]]/route ...

Closes NEXT-1701

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 31, 2023
@ijjk
Copy link
Member

ijjk commented Oct 31, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 31, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js polish-logging-path Change
buildDuration 10.6s 10.7s N/A
buildDurationCached 6.1s 6.1s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +3.74 kB
nextStartRea..uration (ms) 399ms 402ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js polish-logging-path Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js polish-logging-path Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js polish-logging-path Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary vercel/next.js polish-logging-path Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js polish-logging-path Change
index.html gzip 528 B 527 B N/A
link.html gzip 542 B 544 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js polish-logging-path Change
edge-ssr.js gzip 96.1 kB 96.2 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js polish-logging-path Change
middleware-b..fest.js gzip 626 B 626 B
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Commit: 90313e8

@huozhi huozhi force-pushed the polish-logging-path branch from 7b3cec4 to 27e6894 Compare October 31, 2023 21:02
@huozhi huozhi marked this pull request as ready for review October 31, 2023 22:13
ztanner
ztanner previously approved these changes Nov 1, 2023
packages/next/src/build/output/index.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 6b6bfcd into canary Nov 1, 2023
52 of 57 checks passed
@kodiakhq kodiakhq bot deleted the polish-logging-path branch November 1, 2023 16:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants