Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @highlight-run/node to externals list #57783

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

Vadman97
Copy link
Contributor

This is a native module that uses node.js features, so it should be externalized by default.
Related to #52091

cc @deltaepsilon

@Vadman97 Vadman97 marked this pull request as ready for review October 30, 2023 22:37
This is a native module that uses node.js features, so it should be externalized by default.

Co-authored-by: Chris Esplin <[email protected]>
@Vadman97 Vadman97 mentioned this pull request Oct 30, 2023
9 tasks
@ijjk ijjk added the CI approved Approve running CI for fork label Oct 31, 2023
@ijjk
Copy link
Member

ijjk commented Oct 31, 2023

Stats from current PR

Default Build
General
vercel/next.js canary highlight/next.js canary Change
buildDuration 10.3s 10.3s N/A
buildDurationCached 6s 5.9s N/A
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 417ms 413ms N/A
Client Bundles (main, webpack)
vercel/next.js canary highlight/next.js canary Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary highlight/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary highlight/next.js canary Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary highlight/next.js canary Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary highlight/next.js canary Change
index.html gzip 527 B 527 B
link.html gzip 541 B 543 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 527 B 527 B
Edge SSR bundle Size
vercel/next.js canary highlight/next.js canary Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary highlight/next.js canary Change
middleware-b..fest.js gzip 626 B 626 B
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 23 kB 23 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Commit: b04074e

@ijjk ijjk merged commit f3bba78 into vercel:canary Oct 31, 2023
56 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants