Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverActions.allowedForwardedHosts option #57529

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Add serverActions.allowedForwardedHosts option #57529

merged 9 commits into from
Nov 1, 2023

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 26, 2023

This new option specifies a list of host names that are considered safe, to accept as Server Action requests if they're different from the initial request origin. It can be very helpful when the hosted app has many layers of reverse proxies ahead.

Closes #57397.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 26, 2023
@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 27, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js shu/5b9a Change
buildDuration 10.8s 10.7s N/A
buildDurationCached 5.9s 6s ⚠️ +113ms
nodeModulesSize 175 MB 175 MB ⚠️ +14.4 kB
nextStartRea..uration (ms) 418ms 426ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js shu/5b9a Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js shu/5b9a Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js shu/5b9a Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary vercel/next.js shu/5b9a Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js shu/5b9a Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 542 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js shu/5b9a Change
edge-ssr.js gzip 96.2 kB 96.2 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js shu/5b9a Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: 0586386

@shuding shuding changed the title Add serverActions.allowedForwardedHosts option Add serverActions.allowedForwardingHosts option Oct 28, 2023
@shuding shuding marked this pull request as ready for review October 28, 2023 01:19
@vercel-spaces
Copy link

vercel-spaces bot commented Oct 30, 2023

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @huozhi:

packages/next/src/server/config.ts

@shuding shuding changed the title Add serverActions.allowedForwardingHosts option Add serverActions.allowedForwardedHosts option Oct 30, 2023
timneutkens
timneutkens previously approved these changes Oct 31, 2023
timneutkens
timneutkens previously approved these changes Nov 1, 2023
@kodiakhq kodiakhq bot merged commit 937254e into canary Nov 1, 2023
52 of 57 checks passed
@kodiakhq kodiakhq bot deleted the shu/5b9a branch November 1, 2023 12:20
kodiakhq bot pushed a commit that referenced this pull request Nov 3, 2023
Follow-up to #57529, this adds extra logging so that you know what the header value was in order to configure it correctly.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X-Forwarded-* Headers are overwritten
3 participants