Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove throw for unknown messages in hot-reloader-client #57353

Conversation

timneutkens
Copy link
Member

Ensures extra messages are ignored instead of throwing an error.

@timneutkens
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijjk
Copy link
Member

ijjk commented Oct 24, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
buildDuration 10.5s 10.4s N/A
buildDurationCached 6s 6.6s ⚠️ +666ms
nodeModulesSize 175 MB 175 MB N/A
nextStartRea..uration (ms) 414ms 422ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
199-HASH.js gzip 30.5 kB 30.5 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.71 kB 2.7 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
edge-ssr.js gzip 96.4 kB 96.4 kB N/A
page.js gzip 141 kB 141 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client Change
middleware-b..fest.js gzip 626 B 626 B
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Commit: c0319c4

@ijjk
Copy link
Member

ijjk commented Oct 24, 2023

Tests Passed

@kodiakhq kodiakhq bot merged commit 520fbc8 into canary Nov 3, 2023
54 of 59 checks passed
@kodiakhq kodiakhq bot deleted the 10-24-Remove_throw_for_unknown_messages_in_hot-reloader-client branch November 3, 2023 01:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants