Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enabled the disabled manifest test #55810

Merged
merged 6 commits into from
Sep 23, 2023
Merged

test: re-enabled the disabled manifest test #55810

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3837528
Simplify server reference manifest
huozhi Sep 22, 2023
30e4469
fix
huozhi Sep 22, 2023
2b560b9
Merge branch 'canary' into simplify-manifest
huozhi Sep 22, 2023
1d8ba02
Merge branch 'canary' into simplify-manifest
huozhi Sep 22, 2023
d3f4006
Merge branch 'canary' into simplify-manifest
huozhi Sep 23, 2023
3cfbf59
Update packages/next/src/build/webpack/plugins/flight-client-entry-pl…
huozhi Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions test/e2e/app-dir/rsc-basic/rsc-basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,16 @@ createNextDescribe(
},
({ next, isNextDev, isNextStart, isTurbopack }) => {
if (isNextDev && !isTurbopack) {
// TODO: Fix this test, it no longer uses stringified JSON.
it.skip('should have correct client references keys in manifest', async () => {
it('should have correct client references keys in manifest', async () => {
await next.render('/')
await check(async () => {
// Check that the client-side manifest is correct before any requests
const clientReferenceManifest = JSON.parse(
JSON.parse(
(
await next.readFile(
'.next/server/app/page_client-reference-manifest.js'
)
).match(/]=(.+)$/)[1]
)
(
await next.readFile(
'.next/server/app/page_client-reference-manifest.js'
)
).match(/]=(.+)$/)[1]
)
const clientModulesNames = Object.keys(
clientReferenceManifest.clientModules
Expand Down
Loading