improve publish-release #55597
Merged
improve publish-release #55597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
styfle
reviewed
Sep 19, 2023
| } finally { | ||
| publishSema.release() | ||
| } | ||
| } | ||
|
|
||
| await Promise.all( | ||
| await Promise.allSettled( |
There was a problem hiding this comment.
Is the idea here that we don't want to error if one of the packages doesn't publish?
Perhaps this should print the status so we know which ones rejected?
There was a problem hiding this comment.
The idea is that it should finish all packages even if one of them failed.
There was a problem hiding this comment.
Doe this relate to the jump to 13.5.0 release and related canary's?
feedthejim
approved these changes
Sep 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WEB-1608