Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on older browsers #54597

Closed
wants to merge 1 commit into from
Closed

Conversation

philipheinser
Copy link

No description provided.

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify which older browsers? Do you have a reproduction for this?

https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#browser_compatibility shows that we should be covered in all browsers that Next.js supports by default.

https://nextjs.org/docs/architecture/supported-browsers

If you need to support something older, you can check out https://nextjs.org/docs/architecture/supported-browsers#browserslist

Let's open an issue for this first, with a reproduction so we can investigate

@philipheinser
Copy link
Author

Screenshot 2023-08-31 at 11 07 47

@balazsorban44 the docs say Safari 12+ is supported you are using not only measure but also Returns PerformanceMeasure from the table you linked and it says 14.5 (Released 2021-04-26)

@philipheinser
Copy link
Author

@balazsorban44 beforeHydrationMeasure is undefined in browsers Safari 12+ that you support. I don't get why the pr is closed.

@philipheinser
Copy link
Author

@balazsorban44 Everywhere else in the file messument results are read with performance.getEntriesByName for the reason that it returns undefined in browsers like Safari 13 for example.

@balazsorban44
Copy link
Member

balazsorban44 commented Aug 31, 2023

My bad! Looks like one of my colleagues came to the same conclusion, here is their PR #54808

The MDN docs said that the return value should not be undefined.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants