-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crash on older browsers #54597
fix crash on older browsers #54597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Secrets | 0 0 0 0 | View in Orca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you specify which older browsers? Do you have a reproduction for this?
https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#browser_compatibility shows that we should be covered in all browsers that Next.js supports by default.
https://nextjs.org/docs/architecture/supported-browsers
If you need to support something older, you can check out https://nextjs.org/docs/architecture/supported-browsers#browserslist
Let's open an issue for this first, with a reproduction so we can investigate
@balazsorban44 the docs say |
@balazsorban44 |
@balazsorban44 Everywhere else in the file messument results are read with |
My bad! Looks like one of my colleagues came to the same conclusion, here is their PR #54808 The MDN docs said that the return value should not be undefined. |
No description provided.