Update Contentful example for App Router. #54205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerob
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi and
a team
as code owners
ijjk
added
examples
styfle
reviewed
Aug 18, 2023
Co-authored-by: Steven <[email protected]>
styfle
approved these changes
Aug 21, 2023
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority |
|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
cms-contentfulexample to use:revalidateTag)Further, it combines many separate files into more manageable single files, and tries to better bucket provider-specific logic into the
lib/folder. I'm hoping this can be the foundation for re-writing the rest of thecms-*examples to use App Router.Overall, the code is much easier to reason about IMO. Pretty happy with the change. I sprinkled some
any's throughout here, but if someone wants to make it better, go for it!https://app-router-contentful.vercel.app/