Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add missing parameters to both useSelectedLayoutSegment & useSelectedLayoutSegments #53602

Merged
merged 9 commits into from
Aug 24, 2023
Merged

docs: Add missing parameters to both useSelectedLayoutSegment & useSelectedLayoutSegments #53602

merged 9 commits into from
Aug 24, 2023

Conversation

AhmedBaset
Copy link
Contributor

This PR adds missing parameters to the useSelectedLayoutSegment & useSelectedLayoutSegments hooks since they take optional parallelRoutesKey.

@AhmedBaset AhmedBaset requested review from a team as code owners August 5, 2023 08:35
leerob
leerob previously approved these changes Aug 24, 2023
View reviewed changes
@leerob leerob changed the title Docs: Add missing parameters to both useSelectedLayoutSegment & useSelectedLayoutSegments docs: Add missing parameters to both useSelectedLayoutSegment & useSelectedLayoutSegments Aug 24, 2023
@leerob
Copy link
Member

leerob commented Aug 24, 2023

Lint is failing, could you address please?

@AhmedBaset
Copy link
Contributor Author

Lint is failing, could you address please?

I've formatted with prettier. Can you please approve the changes to let the workflow rerun?

@AhmedBaset
Copy link
Contributor Author

still getting This workflow is awaiting approval from a maintainer in https://github.com/vercel/next.js/pull/53602

@ijjk
Copy link
Member

ijjk commented Aug 24, 2023 •
edited by styfle
Loading

Allow CI Workflow Run

  • approve CI run for commit: 6b3e426

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Aug 24, 2023 •
edited by styfle
Loading

Allow CI Workflow Run

  • approve CI run for commit: 6b3e426

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@styfle styfle added the CI approved Approve running CI for fork label Aug 24, 2023
@kodiakhq kodiakhq bot merged commit 7ac6bb1 into vercel:canary Aug 24, 2023
@github-actions github-actions bot added the locked label Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit was automatically assigned from vercel/devex

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhmedBaset @leerob @ijjk @styfle