Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): enable React Strict Mode by default #53375

Merged
merged 11 commits into from
Aug 22, 2023
Merged

fix(app): enable React Strict Mode by default #53375

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
af545a5
fix: enable React Strict Mode by default
balazsorban44 Jul 31, 2023
36fd16a
allow `null` for `reactStrictMode`
balazsorban44 Jul 31, 2023
b81a0f9
Merge branch 'canary' into fix/strict-mode-default
balazsorban44 Jul 31, 2023
7892069
Merge branch 'canary' into fix/strict-mode-default
balazsorban44 Aug 1, 2023
95a07cd
add test
balazsorban44 Aug 1, 2023
d4f26af
Merge branch 'canary' into fix/strict-mode-default
balazsorban44 Aug 1, 2023
ff1b75a
remove empty config
balazsorban44 Aug 1, 2023
da645fa
Merge branch 'canary' into fix/strict-mode-default
balazsorban44 Aug 7, 2023
492239d
Merge branch 'canary' into fix/strict-mode-default
timneutkens Aug 21, 2023
fd2d6f4
fix test
balazsorban44 Aug 21, 2023
9b2dd4b
make AppRouterAnnouncer resilient to Strict Mode
balazsorban44 Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/next/src/server/config-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,7 @@ const configSchema = {
},
reactStrictMode: {
type: 'boolean',
nullable: true,
},
redirects: {
isFunction: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/server/config-shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ export const defaultConfig: NextConfig = {
serverRuntimeConfig: {},
publicRuntimeConfig: {},
reactProductionProfiling: false,
reactStrictMode: false,
reactStrictMode: null,
httpAgentOptions: {
keepAlive: true,
},
Expand Down
7 changes: 7 additions & 0 deletions test/development/app-dir/strict-mode-enabled-by-default/app/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export default function Root({ children }) {
return (
<html>
<body>{children}</body>
</html>
)
}
9 changes: 9 additions & 0 deletions test/development/app-dir/strict-mode-enabled-by-default/app/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use client'
import { useEffect } from 'react'

let i = 1
export default function Page() {
useEffect(() => {
console.log(`logged ${i++} times`)
}, [])
}
22 changes: 22 additions & 0 deletions ...development/app-dir/strict-mode-enabled-by-default/strict-mode-enabled-by-default.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { createNextDescribe } from 'e2e-utils'
import { BrowserInterface } from 'test/lib/browsers/base'

createNextDescribe(
'Strict Mode enabled by default',
{
files: __dirname,
},
({ next }) => {
// Recommended for tests that need a full browser
it('should work using browser', async () => {
const browser: BrowserInterface = await next.browser('/')
const logs = await browser.log()
expect(logs.length).toBe(2)
logs.forEach((log, i) => {
if (log.source === 'log') {
expect(log.message).toBe(`logged ${i + 1}`)
}
})
})
}
)