Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: update with-supabase example to App Router #51335

Merged
merged 14 commits into from
Jun 16, 2023
Merged

examples: update with-supabase example to App Router #51335

merged 14 commits into from
Jun 16, 2023

Conversation

dijonmusters
Copy link
Contributor

@dijonmusters dijonmusters commented Jun 15, 2023 •
edited
Loading

What?

Update Next.js with Supabase example

Why?

Existing example for Next.js with Supabase is out of date

How?

  • Rename with-supabase-auth-db-realtime to with-supabase
  • Update example to use App Router
  • Use Supabase Auth Helpers for Next.js to configure auth cookies

@ijjk ijjk added area: documentation examples Issue was opened via the examples template. labels Jun 15, 2023
@vercel-spaces vercel-spaces bot requested a review from Nutlope June 15, 2023 07:10
@dijonmusters dijonmusters force-pushed the chore/update-supabase-example branch from cf3373f to 92c09cf Compare June 15, 2023 07:10
@dijonmusters dijonmusters force-pushed the chore/update-supabase-example branch from 92c09cf to e962e34 Compare June 15, 2023 07:12
balazsorban44
balazsorban44 previously requested changes Jun 15, 2023
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some small feedback to adhere to https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md

In addition, could you also convert the example to TypeScript? Thanks!

examples/with-supabase/package.json Outdated Show resolved Hide resolved
examples/with-supabase/package.json Outdated Show resolved Hide resolved
examples/with-supabase/package.json Outdated Show resolved Hide resolved
examples/with-supabase/tailwind.config.js Outdated Show resolved Hide resolved
@balazsorban44 balazsorban44 mentioned this pull request Jun 15, 2023
Closed
2 tasks
leerob
leerob reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use TypeScript in this example please?

@dijonmusters dijonmusters force-pushed the chore/update-supabase-example branch from 977ea58 to c4de31e Compare June 16, 2023 00:59
@dijonmusters
Copy link
Contributor Author

@balazsorban44 and @leerob thanks for the review 🙌

Example is now TS 👍

@dijonmusters dijonmusters force-pushed the chore/update-supabase-example branch from d18e3bf to 02766b6 Compare June 16, 2023 01:17
leerob
leerob reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a deploy example I can test this out?

@dijonmusters
Copy link
Contributor Author

Is there a deploy example I can test this out?

https://with-supabase.vercel.app

@ijjk
Copy link
Member

ijjk commented Jun 16, 2023 •
edited by leerob
Loading

Allow CI Workflow Run

  • approve CI run for commit: 0c0389f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Jun 16, 2023

Allow CI Workflow Run

  • approve CI run for commit: 0c0389f

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@leerob leerob changed the title Chore: update with-supabase example to App Router examples: update with-supabase example to App Router Jun 16, 2023
@ijjk ijjk merged commit 3cac097 into vercel:canary Jun 16, 2023
@dijonmusters dijonmusters mentioned this pull request Jun 21, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viniciusanchieta viniciusanchieta viniciusanchieta approved these changes

@ijjk ijjk ijjk approved these changes

@leerob leerob leerob approved these changes

@Nutlope Nutlope Awaiting requested review from Nutlope

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dijonmusters @ijjk @leerob @balazsorban44 @viniciusanchieta