Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(workflow): generate run summary for all build targets #51057

Merged
merged 4 commits into from
Jun 10, 2023
Merged

ci(workflow): generate run summary for all build targets #51057

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52bbed5
ci(workflow): correctly generate runs summary for all targets
kwonoj Jun 9, 2023
b2157f2
Merge branch 'canary' into allow-non-exist-deploy-cache
kodiakhq[bot] Jun 9, 2023
6cd042b
Merge branch 'canary' into allow-non-exist-deploy-cache
kodiakhq[bot] Jun 9, 2023
f03080c
Merge branch 'canary' into allow-non-exist-deploy-cache
kodiakhq[bot] Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_and_deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
- host: windows-latest
build: |
npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}" "turbo@${TURBO_VERSION}" "pnpm@${PNPM_VERSION}"
turbo run build-native-no-plugin -- --release --target i686-pc-windows-msvc
turbo run build-native-no-plugin --summarize -- --release --target i686-pc-windows-msvc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR description says --summary but here you used --summarize.

Which one is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--summarize is correct, it's copied from existing ones (https://github.com/vercel/next.js/pull/51057/files#diff-8812abff9ed11e2e98d5066031a3181c6d44b28aea00f0d369532d5cb254650fR84). PR body is simple mistake.

target: 'i686-pc-windows-msvc'
- host: ubuntu-latest
target: 'x86_64-unknown-linux-gnu'
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
target: 'aarch64-pc-windows-msvc'
build: |
npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}" "turbo@${TURBO_VERSION}" "pnpm@${PNPM_VERSION}"
turbo run build-native-no-plugin-woa-release -- --target aarch64-pc-windows-msvc
turbo run build-native-no-plugin-woa-release --summarize -- --target aarch64-pc-windows-msvc
needs: build
name: stable - ${{ matrix.settings.target }} - node@16
runs-on: ${{ matrix.settings.host }}
Expand Down