Update 10-router-handlers.mdx - Switcher Created + Small Syntax Improvement #51003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I first saw this section, I got confused due to the wrongly named file ending and the multiline TypeScript syntax.
What I did was added a TS and JS switcher. I also changed the TypeScript syntax for { params } : { params: { slug: string }}
This is how I saw it written in the example in 05-dynamic-routes of the documentation and I think it is much easier to read and less confusing.
leerob
reviewed
Jun 9, 2023
docs/02-app/01-building-your-application/01-routing/10-router-handlers.mdx
Outdated
Show resolved
Hide resolved
leerob
approved these changes
Jun 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a TS and JS switcher. Previously the code snippet did not have a switcher. The file extension was .js when the code was TypeScript which made it confusing to try to read.