Polish error page styling #50916
Merged
Polish error page styling #50916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix status mobile fix 404 text align
huozhi
requested review from
timneutkens,
ijjk,
shuding and
feedthejim
as code owners
ijjk
approved these changes
Jun 7, 2023
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
Polish default client error page styling: * shrink the `line-height` to `2em` for better mobile display * remove `text-align: left` to let the text center properly #### After vs Before (both **app router** and **pages** default client error page) <p> <img width="300" alt="image" src="https://github.com/vercel/next.js/assets/4800338/de7260af-7046-4783-8f82-8ac5f39f25b7"> <img width="300" alt="image" src="https://github.com/vercel/next.js/assets/4800338/f4207809-f11f-448d-95ec-0a32b54f3562"> </p> #### After (both **app router** and **pages** default client error page) Closes NEXT-1263
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polish default client error page styling:
line-heightto2emfor better mobile displaytext-align: leftto let the text center properlyAfter vs Before
(both app router and pages default client error page)
After
(both app router and pages default client error page)
Closes NEXT-1262