Bail out of 404 page when favicon.ico doesn't exist #50795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi and
feedthejim
as code owners
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
feedthejim
approved these changes
Jun 6, 2023
timneutkens
deleted the
06-05-Bail_out_of_404_page_when_favicon.ico_doesn_t_exist
branch
1 task
sprioleau
added a commit
to sprioleau/sprioleau.dev
that referenced
this pull request
Jun 7, 2023
Fonger
reviewed
Jun 7, 2023
| @@ -2371,6 +2371,14 @@ export default abstract class Server<ServerOptions extends Options = Options> { | |||
| ctx: RequestContext, | |||
| err: Error | null | |||
| ): Promise<ResponsePayload | null> { | |||
| // Short-circuit favicon.ico in development to avoid compiling 404 page when the app has no favicon.ico. | |||
| // Since favicon.ico is automatically requested by the browser. | |||
| if (this.renderOpts.dev && ctx.pathname === '/favicon.ico') { | |||
There was a problem hiding this comment.
Maybe short-circuit in production is also a good idea. It wastes server to render full html 404 page that browser can't load as icon
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
## What? Anytime you open a Next.js application that doesn't have a `favicon.ico` you'll notice `/_error` is being compiled because the browser requests `favicon.ico`. This PR ensures the 404 page is not compiled in development for that request. It helps a little with compilation speed. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Anytime you open a Next.js application that doesn't have a
favicon.icoyou'll notice/_erroris being compiled because the browser requestsfavicon.ico. This PR ensures the 404 page is not compiled in development for that request. It helps a little with compilation speed.