Add new build and test workflow #50436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
Turbopack
ijjk
force-pushed
the
ijjk/update-ci-workflow
branch
6 times, most recently
from
1e79d26
to
37b5e40
Compare
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
ijjk
force-pushed
the
ijjk/update-ci-workflow
branch
4 times, most recently
from
1e22c65
to
e76e708
Compare
ijjk
force-pushed
the
ijjk/update-ci-workflow
branch
from
e76e708
to
9fdc180
Compare
ijjk
requested review from
timneutkens,
shuding,
a team,
padmaia,
styfle,
huozhi and
feedthejim
as code owners
|
@ijjk is the thank you, next there to check if GitHub Actions itself is functioning properly? |
styfle
reviewed
May 30, 2023
| @@ -0,0 +1,430 @@ | |||
| name: build-and-deploy | |||
There was a problem hiding this comment.
Is this temp file build_and_deploy.yml.tmp needed?
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
This adds new `build and test` and `build and deploy` workflows in favor of the existing massive `build, test, and deploy` workflow. Since the new workflows will use `pull_request_target` this waits to remove the existing workflow until the new one is tested. While testing this new workflow flakey behavior in tests have also been addressed. Along with the new workflow we will also be leveraging new runners which allow us to run tests against the production binary of `next-swc` so this avoids slight differences in tests we've seen due to running against the dev binary. Furthermore we will have a new flow for allowing workflow runs on PRs from external forks which will either require a comment be checking a box approving the run after each change or a label added by the team. The new flow also no longer relies on `actions/cache` or similar which have proven to be pretty unreliable. Tests runs with the new workflow can be seen here https://github.com/vercel/next.js/actions/runs/5100673508/jobs/9169416949
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new
build and testandbuild and deployworkflows in favor of the existing massivebuild, test, and deployworkflow. Since the new workflows will usepull_request_targetthis waits to remove the existing workflow until the new one is tested.While testing this new workflow flakey behavior in tests have also been addressed. Along with the new workflow we will also be leveraging new runners which allow us to run tests against the production binary of
next-swcso this avoids slight differences in tests we've seen due to running against the dev binary.Furthermore we will have a new flow for allowing workflow runs on PRs from external forks which will either require a comment be checking a box approving the run after each change or a label added by the team.
The new flow also no longer relies on
actions/cacheor similar which have proven to be pretty unreliable.Tests runs with the new workflow can be seen here https://github.com/vercel/next.js/actions/runs/5100673508/jobs/9169416949